Merge pull request #179 from AikidoSec/debug-level-trace-enable-bytebuddy-logs

Allow logLevel = TRACE to enable the bytebuddy debug logs

Author: bitterpanda63

agent/src/main/java/dev/aikido/agent/ByteBuddyInitializer.java

@@ -1,5 +1,7 @@
 package dev.aikido.agent;
 
+import dev.aikido.agent_api.helpers.logging.LogManager;
+import dev.aikido.agent_api.helpers.logging.Logger;
 import net.bytebuddy.ByteBuddy;
 import net.bytebuddy.agent.builder.AgentBuilder;
 import net.bytebuddy.dynamic.VisibilityBridgeStrategy;
@@ -8,12 +10,15 @@
 import net.bytebuddy.matcher.ElementMatchers;
 
 public final class ByteBuddyInitializer {
-
+    private static final Logger logger = LogManager.getLogger(ByteBuddyInitializer.class);
     public static AgentBuilder createAgentBuilder() {
-        return createAgentBuilder(false); // Set debug mode to false by default
+        // byte buddy debug mode should be linked to the trace logs, since we rarely want to inspect them.
+        boolean debugMode = logger.logsTraceLogs();
+        return createAgentBuilder(debugMode);
     }
 
     public static AgentBuilder createAgentBuilder(boolean debugMode) {
+        logger.debug("Creating new ByteBuddy agent, with debugMode: %s", debugMode);
         AgentBuilder agentBuilder = new AgentBuilder.Default(
                 // default method graph compiler inspects the class hierarchy, we don't need it, so
                 // we use a simpler and faster strategy instead
@@ -42,6 +47,7 @@ public static AgentBuilder createAgentBuilder(boolean debugMode) {
 
         agentBuilder = agentBuilder.with(AgentBuilder.TypeStrategy.Default.DECORATE);
 
+        logger.trace("Finished creating new ByteBuddy agent: %s", agentBuilder);
         return agentBuilder;
     }
 }

agent_api/src/main/java/dev/aikido/agent_api/helpers/logging/Logger.java

@@ -106,4 +106,7 @@ public void error(Object message, Object... args) {
     public void fatal(Object message, Object... args) {
         log(LogLevel.FATAL, message, args);
     }
+    public boolean logsTraceLogs() {
+        return LogLevel.TRACE.getLevel() >= logLevel.getLevel();
+    }
 }