Skip to content

Commit 5c3c365

Browse files
committed
domains => outbound_domains rename
1 parent 515da43 commit 5c3c365

2 files changed

Lines changed: 14 additions & 12 deletions

File tree

aikido_zen/background_process/cloud_connection_manager/update_service_config_test.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def test_update_service_config_outbound_blocking():
3434

3535
# Verify that the outbound blocking configuration was set
3636
assert connection_manager.conf.block_new_outgoing_requests is True
37-
assert connection_manager.conf.domains == {
37+
assert connection_manager.conf.outbound_domains == {
3838
"example.com": "block",
3939
"allowed.com": "allow",
4040
}
@@ -61,7 +61,7 @@ def test_update_service_config_outbound_blocking_false():
6161

6262
# Verify that the outbound blocking configuration was set
6363
assert connection_manager.conf.block_new_outgoing_requests is False
64-
assert connection_manager.conf.domains == {}
64+
assert connection_manager.conf.outbound_domains == {}
6565

6666

6767
def test_update_service_config_outbound_blocking_missing():
@@ -89,7 +89,7 @@ def test_update_service_config_outbound_blocking_missing():
8989

9090
# Verify that the outbound blocking configuration was not changed
9191
assert connection_manager.conf.block_new_outgoing_requests is False
92-
assert connection_manager.conf.domains == {}
92+
assert connection_manager.conf.outbound_domains == {}
9393

9494

9595
def test_update_service_config_failure():
@@ -119,7 +119,7 @@ def test_update_service_config_failure():
119119

120120
# Verify that nothing was changed due to failure
121121
assert connection_manager.conf.block_new_outgoing_requests is True
122-
assert connection_manager.conf.domains == {"test.com": "block"}
122+
assert connection_manager.conf.outbound_domains == {"test.com": "block"}
123123

124124

125125
def test_update_service_config_complete():
@@ -162,7 +162,7 @@ def test_update_service_config_complete():
162162
assert connection_manager.conf.blocked_uids == {"user1", "user2"}
163163
assert connection_manager.conf.received_any_stats is True
164164
assert connection_manager.conf.block_new_outgoing_requests is True
165-
assert connection_manager.conf.domains == {
165+
assert connection_manager.conf.outbound_domains == {
166166
"blocked.com": "block",
167167
"allowed.com": "allow",
168168
"test.com": "block",
@@ -196,7 +196,7 @@ def test_update_service_config_domains_only():
196196

197197
# Verify that only domains were updated
198198
assert connection_manager.conf.block_new_outgoing_requests is False # Not changed
199-
assert connection_manager.conf.domains == {
199+
assert connection_manager.conf.outbound_domains == {
200200
"api.example.com": "block",
201201
"cdn.example.com": "allow",
202202
}
@@ -231,4 +231,6 @@ def test_update_service_config_block_new_outgoing_requests_only():
231231

232232
# Verify that only blockNewOutgoingRequests was updated
233233
assert connection_manager.conf.block_new_outgoing_requests is True
234-
assert connection_manager.conf.domains == {"existing.com": "allow"} # Not changed
234+
assert connection_manager.conf.outbound_domains == {
235+
"existing.com": "allow"
236+
} # Not changed

aikido_zen/background_process/service_config_test.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def test_service_config_outbound_blocking_initialization():
1717
assert hasattr(config, "block_new_outgoing_requests")
1818
assert hasattr(config, "domains")
1919
assert config.block_new_outgoing_requests is False
20-
assert config.domains == {}
20+
assert config.outbound_domains == {}
2121

2222

2323
def test_service_config_set_block_new_outgoing_requests():
@@ -63,7 +63,7 @@ def test_service_config_update_domains():
6363
)
6464

6565
# Test initial state
66-
assert config.domains == {}
66+
assert config.outbound_domains == {}
6767

6868
# Test updating with domains
6969
domains_data = [
@@ -72,19 +72,19 @@ def test_service_config_update_domains():
7272
{"hostname": "test.com", "mode": "block"},
7373
]
7474
config.update_outbound_domains(domains_data)
75-
assert config.domains == {
75+
assert config.outbound_domains == {
7676
"example.com": "block",
7777
"allowed.com": "allow",
7878
"test.com": "block",
7979
}
8080

8181
# Test updating with empty list
8282
config.update_outbound_domains([])
83-
assert config.domains == {}
83+
assert config.outbound_domains == {}
8484

8585
# Test updating with single domain
8686
config.update_outbound_domains([{"hostname": "single.com", "mode": "allow"}])
87-
assert config.domains == {"single.com": "allow"}
87+
assert config.outbound_domains == {"single.com": "allow"}
8888

8989

9090
def test_service_config_should_block_outgoing_request():

0 commit comments

Comments
 (0)