Revert "Revert "Fix broken test cases by adding an is_empty function""

This reverts commit b446a59.

Author: bitterpanda63

aikido_zen/background_process/cloud_connection_manager/update_firewall_lists_test.py

@@ -141,17 +141,15 @@ def test_update_firewall_lists_no_token(connection_manager):
     connection_manager.token = None
     update_firewall_lists(connection_manager)
     # No changes should be made, so we check the initial state
-    assert len(connection_manager.conf.bypassed_ips.blocked_subnets) == 0
-    assert len(connection_manager.conf.bypassed_ips.blocked_addresses) == 0
+    assert connection_manager.conf.bypassed_ips.is_empty()
 
 
 def test_update_firewall_lists_serverless(connection_manager):
     # Set serverless to True
     connection_manager.serverless = True
     update_firewall_lists(connection_manager)
     # No changes should be made, so we check the initial state
-    assert len(connection_manager.conf.bypassed_ips.blocked_subnets) == 0
-    assert len(connection_manager.conf.bypassed_ips.blocked_addresses) == 0
+    assert connection_manager.conf.bypassed_ips.is_empty()
 
 
 def test_update_firewall_lists_api_failure(connection_manager):
@@ -163,8 +161,7 @@ def fetch_firewall_lists(self, token):
     connection_manager.api = FailingApi()
     update_firewall_lists(connection_manager)
     # No changes should be made, so we check the initial state
-    assert len(connection_manager.conf.bypassed_ips.blocked_subnets) == 0
-    assert len(connection_manager.conf.bypassed_ips.blocked_addresses) == 0
+    assert connection_manager.conf.bypassed_ips.is_empty()
 
 
 def test_update_firewall_lists_exception_handling(connection_manager):
@@ -176,5 +173,4 @@ def fetch_firewall_lists(self, token):
     connection_manager.api = ExceptionApi()
     update_firewall_lists(connection_manager)
     # No changes should be made, so we check the initial state
-    assert len(connection_manager.conf.bypassed_ips.blocked_subnets) == 0
-    assert len(connection_manager.conf.bypassed_ips.blocked_addresses) == 0
+    assert connection_manager.conf.bypassed_ips.is_empty()

aikido_zen/helpers/ip_matcher/__init__.py

@@ -42,3 +42,6 @@ def add(self, network):
             return self
         self.sorted.insert(idx, net)
         return self
+
+    def is_empty(self):
+        return len(self.sorted) == 0