Skip to content

Increase coverage of reported packages & fix recursive bug #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitterpanda63 merged 4 commits into from
Jun 12, 2025
Merged

Increase coverage of reported packages & fix recursive bug #405

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed4f2c6
Remove submodules, still check their version
bitterpanda63 Jun 11, 2025
581d10e
lint
bitterpanda63 Jun 11, 2025
c296f95
Merge branch 'main' into also-check-package-even-if-dots
bitterpanda63 Jun 12, 2025
9abd455
Make sure to also ignore "importlib"
bitterpanda63 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions aikido_zen/sinks/builtins_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ def _import(func, instance, args, kwargs, return_value):
return
name = getattr(return_value, "__package__")

if not name or "." in name:
# Make sure the name exists and that it's not a submodule
if not name:
# Make sure the name exists
return
if name == "importlib_metadata":
name = name.split(".")[0] # Remove submodules
if name == "importlib" or name == "importlib_metadata":
# Avoid circular dependencies
return

Expand Down
Loading