rsyslog: fix octet-counted framing on oversize messages#193
Merged
jclarysse merged 1 commit intoMay 11, 2026
Merged
Conversation
When `octet_counted_framing` is enabled and the encoded message exceeds `max_message_size`, the previous code advertised the full body length in the frame prefix but only sent a truncated body (plus a stray newline). RFC 6587 octet-counted receivers then consumed bytes from the following frame to make up the count, desyncing the entire connection. Truncate the body before computing the prefix length, drop the non-transparent newline in octet-counted mode, and document that `max_message_size` bounds the body bytes in both modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
octet_counted_framingis enabled and the encoded messageexceeds
max_message_size, the previous code advertised the fullbody length in the frame prefix but only sent a truncated body
(plus a stray newline). RFC 6587 octet-counted receivers then
consumed bytes from the following frame to make up the count,
desyncing the entire connection.
Truncate the body before computing the prefix length, drop the
non-transparent newline in octet-counted mode, and document that
max_message_sizebounds the body bytes in both modes.