Fix Windows title menu lifecycle bugs and preserve host Configure bin…#50
Open
sherpya wants to merge 1 commit intoAkascape:mainfrom
Open
Fix Windows title menu lifecycle bugs and preserve host Configure bin…#50sherpya wants to merge 1 commit intoAkascape:mainfrom
sherpya wants to merge 1 commit intoAkascape:mainfrom
Conversation
5bdf92b to
d3e4665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
CTkTitleMenulifecycle issues on Windows.This change prevents stale master callbacks from firing after the title menu has been destroyed, and avoids overwriting existing master event bindings.
Problem
CTkTitleMenucurrently binds master events like this:This causes a few issues:
add="+"is not used<Configure>events may callchange_dimension()on a destroyedCTkTitleMenu, raising:TclError: bad window path name ".!ctktitlemenu"<Map>callback returnsself.withdrawinstead of actually callingself.withdraw()Changes
<Configure>,<Destroy>, and<Map>withadd="+"destroy()/destroy_window()change_dimension()against destroyed widgets<Map>callback to actually callwithdraw()Result
CTkTitleMenuno longer leaves stale callbacks behind after destruction, and it no longer clobbers other master event handlers.Optional note
Tested locally on Windows with a CustomTkinter app using
CTkTitleMenu.