Skip to content

Commit b5ca637

Browse files
committed
Merge remote-tracking branch 'origin/main'
2 parents b670f14 + 179209d commit b5ca637

13 files changed

Lines changed: 47 additions & 24 deletions

File tree

lib/common/dispatchers.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,18 +121,18 @@ export class CommandDispatcher implements ICommandDispatcher {
121121

122122
switch (packageManagerName) {
123123
case PackageManagers.yarn:
124-
case PackageManagers.yarn2:
125-
updateCommand = "yarn global add nativescript";
124+
// case PackageManagers.yarn2:
125+
updateCommand = "yarn global add @akylas/nativescript-cli";
126126
break;
127127
case PackageManagers.pnpm:
128-
updateCommand = "pnpm i -g nativescript";
128+
updateCommand = "pnpm i -g @akylas/nativescript-cli";
129129
break;
130130
case PackageManagers.bun:
131-
updateCommand = "bun add --global nativescript";
131+
updateCommand = "bun add --global @akylas/nativescript-cli";
132132
break;
133133
case PackageManagers.npm:
134134
default:
135-
updateCommand = "npm i -g nativescript";
135+
updateCommand = "npm i -g @akylas/nativescript-cli";
136136
break;
137137
}
138138

lib/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export const APP_FOLDER_NAME = "app";
88
export const APP_RESOURCES_FOLDER_NAME = "App_Resources";
99
export const PROJECT_FRAMEWORK_FOLDER_NAME = "framework";
1010
export const NS_BASE_PODFILE = "NSPodfileBase";
11-
export const NATIVESCRIPT_KEY_NAME = "nativescript";
11+
export const NATIVESCRIPT_KEY_NAME = "@akylas/nativescript-cli";
1212
export const NODE_MODULES_FOLDER_NAME = "node_modules";
1313
export const TNS_MODULES_FOLDER_NAME = "tns_modules";
1414
export const TNS_CORE_MODULES_NAME = "tns-core-modules";

lib/controllers/prepare-controller.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ export class PrepareController extends EventEmitter {
407407
const dependencies = this.$nodeModulesDependenciesBuilder
408408
.getProductionDependencies(
409409
projectData.projectDir,
410-
projectData.ignoredDependencies,
410+
projectData.getIgnoredDependencies(platformData.platformNameLowerCase),
411411
)
412412
.filter((dep) => dep.nativescript);
413413
const pluginsNativeDirectories = dependencies.map((dep) =>
@@ -457,7 +457,7 @@ export class PrepareController extends EventEmitter {
457457
);
458458

459459

460-
const {hooks, ignoredNativeDependencies, webpackPackageName, webpackConfigPath, appResourcesPath, buildPath, appPath, ...nsConfig} = this.$projectConfigService.readConfig(
460+
const {hooks, webpackPackageName, webpackConfigPath, appResourcesPath, buildPath, appPath, ...nsConfig} = this.$projectConfigService.readConfig(
461461
projectData.projectDir
462462
);
463463

lib/definitions/gradle.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,5 @@ interface IGradleBuildService {
3030
interface IGradleBuildArgsService {
3131
getBuildTaskArgs(buildData: IAndroidBuildData): Promise<string[]>;
3232
getCleanTaskArgs(buildData: IAndroidBuildData): string[];
33+
getBuildLoggingArgs(): string[];
3334
}

lib/definitions/project.d.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ export type BundlerType = "webpack" | "rspack" | "vite";
126126
interface INsConfigIOS extends INsConfigPlaform {
127127
discardUncaughtJsExceptions?: boolean;
128128
runtimePackageName?: string
129+
ignoredNativeDependencies?: string[];
129130
cocoapodUseBundleExec?: boolean
130131
/**
131132
* Swift Package Manager
@@ -175,9 +176,11 @@ interface INsConfigAndroid extends INsConfigPlaform {
175176

176177
gradleArgs?: string[];
177178

178-
plugins?:{ [k:string]: { aarSuffix?: string } }
179+
plugins?:{ [k:string]: { aarSuffix?: string } };
179180

180-
runtimePackageName?: string
181+
runtimePackageName?: string;
182+
183+
ignoredNativeDependencies?: string[];
181184
}
182185

183186
interface INsConfigHooks {
@@ -212,7 +215,6 @@ interface IProjectData extends ICreateProjectData {
212215
projectId: string;
213216
projectIdentifiers?: Mobile.IProjectIdentifier;
214217
dependencies: any;
215-
ignoredDependencies?: string[];
216218
devDependencies: IStringDictionary;
217219
appDirectoryPath: string;
218220
appResourcesDirectoryPath: string;
@@ -270,6 +272,7 @@ interface IProjectData extends ICreateProjectData {
270272
getAppResourcesDirectoryPath(projectDir?: string): string;
271273
getAppResourcesRelativeDirectoryPath(): string;
272274
getBuildRelativeDirectoryPath(): string;
275+
getIgnoredDependencies(platform: string): string[];
273276
}
274277

275278
interface IProjectDataService {

lib/project-data.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ export class ProjectData implements IProjectData {
9090
public appResourcesDirectoryPath: string;
9191
public dependencies: any;
9292
public devDependencies: IStringDictionary;
93-
public ignoredDependencies: string[];
9493
public projectType: string;
9594
public androidManifestPath: string;
9695
public infoPlistPath: string;
@@ -180,7 +179,6 @@ export class ProjectData implements IProjectData {
180179
this.dependencies = packageJsonData.dependencies;
181180
this.devDependencies = packageJsonData.devDependencies;
182181
this.projectType = this.getProjectType();
183-
this.ignoredDependencies = nsConfig?.ignoredNativeDependencies;
184182
this.appDirectoryPath = this.getAppDirectoryPath();
185183
this.appResourcesDirectoryPath = this.getAppResourcesDirectoryPath();
186184
this.androidManifestPath = this.getPathToAndroidManifest(
@@ -359,6 +357,18 @@ export class ProjectData implements IProjectData {
359357
return identifier;
360358
}
361359

360+
getIgnoredDependencies(platform: string) {
361+
let ignoredNativeDependencies = this.nsConfig?.ignoredNativeDependencies ?? [];
362+
if (platform === constants.PlatformTypes.visionos) {
363+
ignoredNativeDependencies = ignoredNativeDependencies.concat(this.nsConfig?.visionos?.ignoredNativeDependencies ?? [])
364+
} else if (platform === constants.PlatformTypes.ios) {
365+
ignoredNativeDependencies = ignoredNativeDependencies.concat(this.nsConfig?.ios?.ignoredNativeDependencies ?? [])
366+
} else if (platform === constants.PlatformTypes.android) {
367+
ignoredNativeDependencies = ignoredNativeDependencies.concat(this.nsConfig?.android?.ignoredNativeDependencies ?? [])
368+
}
369+
return ignoredNativeDependencies;
370+
}
371+
362372
private getProjectType(): string {
363373
let detectedProjectType = _.find(
364374
ProjectData.PROJECT_TYPES,

lib/services/android-plugin-build-service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ import { injector } from "../common/yok";
3939
import * as _ from "lodash";
4040
import { resolvePackageJSONPath } from "@rigor789/resolve-package-path";
4141
import { cwd } from "process";
42+
import { IGradleBuildArgsService } from "../definitions/gradle";
4243

4344
export class AndroidPluginBuildService implements IAndroidPluginBuildService {
4445
private get $platformsDataService(): IPlatformsDataService {
@@ -56,6 +57,7 @@ export class AndroidPluginBuildService implements IAndroidPluginBuildService {
5657
private $projectData: IProjectData,
5758
private $projectDataService: IProjectDataService,
5859
private $devicePlatformsConstants: Mobile.IDevicePlatformsConstants,
60+
private $gradleBuildArgsService: IGradleBuildArgsService,
5961
private $errors: IErrors,
6062
private $filesHashService: IFilesHashService,
6163
public $hooksService: IHooksService,
@@ -812,10 +814,8 @@ export class AndroidPluginBuildService implements IAndroidPluginBuildService {
812814
});
813815
localArgs.push(...additionalArgs);
814816
}
817+
localArgs.push(...this.$gradleBuildArgsService.getBuildLoggingArgs());
815818

816-
if (this.$logger.getLevel() === "INFO") {
817-
localArgs.push("--info");
818-
}
819819

820820
const opts: any = {
821821
cwd: pluginBuildSettings.pluginDir,

lib/services/android/gradle-build-args-service.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ export class GradleBuildArgsService implements IGradleBuildArgsService {
5757
this.$projectData.initializeProjectData(buildData.projectDir);
5858

5959
args.push(
60-
`--stacktrace`,
6160
`-PcompileSdk=${toolsInfo.compileSdkVersion}`,
6261
`-PtargetSdk=${toolsInfo.targetSdkVersion}`,
6362
`-PbuildToolsVersion=${toolsInfo.buildToolsVersion}`,
@@ -92,18 +91,23 @@ export class GradleBuildArgsService implements IGradleBuildArgsService {
9291
`-PksPassword=${buildData.keyStorePassword}`
9392
);
9493
}
94+
console.log('getBuildTaskArgs', args);
9595

9696
return args;
9797
}
9898

99-
private getBuildLoggingArgs(): string[] {
99+
public getBuildLoggingArgs(): string[] {
100100
const args = [];
101101

102102
const logLevel = this.$logger.getLevel();
103103
if (logLevel === LoggerLevel.TRACE) {
104+
args.push("--stacktrace");
104105
args.push("--debug");
105106
} else if (logLevel === LoggerLevel.DEBUG) {
107+
args.push("--stacktrace");
106108
args.push("--info");
109+
} else if (logLevel === LoggerLevel.INFO) {
110+
args.push("--quiet");
107111
}
108112

109113
return args;

lib/services/plugins-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ export class PluginsService implements IPluginsService {
352352
dependencies ||
353353
this.$nodeModulesDependenciesBuilder.getProductionDependencies(
354354
projectData.projectDir,
355-
projectData.ignoredDependencies
355+
projectData.getIgnoredDependencies(platform)
356356
);
357357

358358
if (_.isEmpty(dependencies)) {

lib/services/project-changes-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export class ProjectChangesService implements IProjectChangesService {
109109
this.$nodeModulesDependenciesBuilder
110110
.getProductionDependencies(
111111
projectData.projectDir,
112-
projectData.ignoredDependencies
112+
projectData.getIgnoredDependencies(platformData.platformNameLowerCase)
113113
)
114114
.filter(
115115
(dep) =>

0 commit comments

Comments
 (0)