Merge pull request #52 from AlCalzone/fix-51

Don't include transitionTime=null in sent payloads

Author: AlCalzone

README.md

@@ -504,6 +504,7 @@ A DeviceInfo object contains general information about a device. It has the foll
 
 #### NEXT:
 * (AlCalzone) Swallow `"CoapClient was reset"` promise rejections and emit an `"error"` instead
+* (AlCalzone) Avoid sending `5712: null` in payloads when a group's transition time is `null` for some reason
 
 #### 0.9.1 (2018-03-09)
 * (AlCalzone) Fix properties which are wrongly reported by the gateway

build/lib/conversions.js

@@ -200,7 +200,7 @@ const saturation_in = (value /*, light: Light*/) => {
 // ===========================
 // TRANSITION TIME conversions
 // the sent value is in 10ths of seconds, we're working with seconds
-const transitionTime_out = val => val * 10;
+const transitionTime_out = val => val && val * 10; // "val && " avoids sending `null` if val is null for some reason
 // the sent value is in 10ths of seconds, we're working with seconds
 const transitionTime_in = val => val / 10;
 // ===========================

src/lib/conversions.ts

@@ -200,7 +200,7 @@ const saturation_in: PropertyTransformKernel = (value /*, light: Light*/) => {
 // TRANSITION TIME conversions
 
 // the sent value is in 10ths of seconds, we're working with seconds
-const transitionTime_out: PropertyTransformKernel = val => val * 10;
+const transitionTime_out: PropertyTransformKernel = val => val && val * 10; // "val && " avoids sending `null` if val is null for some reason
 // the sent value is in 10ths of seconds, we're working with seconds
 const transitionTime_in: PropertyTransformKernel = val => val / 10;
 

src/lib/group.test.ts

@@ -47,6 +47,18 @@ describe("ipso/group => basic functionality => ", () => {
 		expect(group.serialize()).to.deep.equal(template);
 	});
 
+	it(`should serialize correctly when transitionTime has the value "null"`, () => {
+		// repro for issue#51
+		const brokenGroup = group.clone();
+		brokenGroup.transitionTime = null;
+		const reference = brokenGroup.clone();
+		brokenGroup.onOff = !brokenGroup.onOff;
+
+		expect(brokenGroup.serialize(reference)).to.deep.equal({
+			5850: brokenGroup.onOff ? 1 : 0,
+		});
+	});
+
 });
 
 describe("ipso/group => simplified API => ", () => {