remove uint from modrefere check too

Author: AnakinRaW

src/EawModinfo.Tests/ModinfoValidatorTests.cs

@@ -246,6 +246,9 @@ public static IEnumerable<object[]> GetModReferences()
         yield return [new ModReference { Identifier = "123456", Type = ModType.Default }, false];
         yield return [new ModReference { Identifier = "123456", Type = ModType.Workshops }, false];
         yield return [new ModReference { Identifier = "blabla", Type = ModType.Virtual }, false];
+        yield return [new ModReference { Identifier = ulong.MaxValue.ToString(), Type = ModType.Workshops }, false];
+        yield return [new ModReference { Identifier = "1" + ulong.MaxValue, Type = ModType.Workshops }, false];
+        yield return [new ModReference { Identifier = "abcdef", Type = ModType.Workshops }, false];
     }
 
     public static IEnumerable<object[]> GetInvalidModReferences()
@@ -261,12 +264,10 @@ public static IEnumerable<object[]> GetInvalidModReferences()
         ];
         yield return [new ModReference { Identifier = null!, Type = ModType.Workshops }, true];
         yield return [new ModReference { Identifier = null!, Type = ModType.Virtual }, true];
+        yield return [new ModReference { Identifier = null!, Type = ModType.Default }, true];
         yield return [new ModReference { Identifier = string.Empty, Type = ModType.Default }, true];
         yield return [new ModReference { Identifier = string.Empty, Type = ModType.Workshops }, true];
         yield return [new ModReference { Identifier = string.Empty, Type = ModType.Virtual }, true];
-        yield return [new ModReference { Identifier = "-1", Type = ModType.Workshops }, true];
-        yield return [new ModReference { Identifier = "0", Type = ModType.Workshops }, true];
-        yield return [new ModReference { Identifier = "12921908098098098309481234", Type = ModType.Workshops }, true];
         yield return [new ModReference { Identifier = "1234", Type = (ModType) 0xff }, true];
     }
 

src/EawModinfo/Utilities/ModinfoValidator.cs

@@ -85,30 +85,16 @@ private static bool ContainsInvalidCharacter(ReadOnlySpan<char> value)
 
     /// <summary>
     /// Validates an <see cref="IModReference"/> data. Throws an <see cref="ModinfoException"/> when validation failed.
+    /// That is when the identifier is <see langword="null"/> or an empty string.
     /// </summary>
-    /// <remarks>
-    /// When <see cref="IModReference.Type"/> is <see cref="ModType.Workshops"/>:
-    /// <see cref="IModReference.Identifier"/> must parse into an <see cref="uint"/> larger than 0.
-    /// <br></br>
-    /// The validator will not check for if the <see cref="IModReference.Identifier"/> is a valid file system path.
-    /// </remarks>
     /// <param name="modReference">The data to validate.</param>
     /// <exception cref="ModinfoException">The validation failed.</exception>
     public static void Validate(this IModReference modReference)
     {
         if (string.IsNullOrEmpty(modReference.Identifier))
             throw new ModinfoException("Mod-Reference data is invalid: Identifier is missing.");
-        switch (modReference.Type)
-        {
-            case ModType.Workshops:
-                ValidateSteamId(modReference.Identifier, $"Mod-Reference data is invalid: '{modReference}'");
-                break;
-            case ModType.Default:
-            case ModType.Virtual:
-                break;
-            default:
-                throw new ModinfoException($"ERROR: Unknown ModType! ({modReference.Type})");
-        }
+        if (!Enum.IsDefined(typeof(ModType), modReference.Type))
+            throw new ModinfoException("Mod-Reference data is invalid: ModType not valid.");
     }
 
     /// <summary>
@@ -154,7 +140,7 @@ private static (bool Valid, string Error) ValidateSteamId(string data)
         if (data[0] == '0')
             return (false, "Workshops ID cannot have leading zeros.");
         if (!ulong.TryParse(data, NumberStyles.None, CultureInfo.InvariantCulture, out var id))
-            return (false, "Workshops ID must be an uint number.");
+            return (false, "Workshops ID must be an ulong number.");
         if (id == 0)
             return (false, "Workshops ID cannot be 0.");
         return (true, string.Empty);