start testing automatic selector

Author: AnakinRaW

src/ModVerify.CliApp/TargetSelectors/AutomaticSelector.cs

@@ -20,8 +20,7 @@ internal class AutomaticSelector(IServiceProvider serviceProvider) : Verificatio
 {
     private readonly IFileSystem _fileSystem = serviceProvider.GetRequiredService<IFileSystem>();
 
-    internal override SelectionResult SelectTarget(
-        VerificationTargetSettings settings)
+    internal override SelectionResult SelectTarget(VerificationTargetSettings settings)
     {
         var targetPath = settings.TargetPath;
         if (targetPath is null)
@@ -76,7 +75,7 @@ internal override SelectionResult SelectTarget(
         // If the target is the game directory itself.
         if (targetFullPath.Equals(finderResult.Game.Directory.FullName, StringComparison.OrdinalIgnoreCase))
         {
-            if (finderResult.Game.Type.ToEngineType() != requestedEngineType)
+            if (!IsEngineTypeSupported(requestedEngineType, finderResult.Game))
                 throw new ArgumentException($"The specified game type '{requestedEngineType}' does not match the actual type of the game '{targetPath}' to verify.");
             return finderResult.Game;
         }
@@ -144,4 +143,9 @@ private GameLocations GetDetachedModLocations(string modPath, GameFinderResult g
 
         return null;
     }
+    
+    private static bool IsEngineTypeSupported(GameEngineType? requestedEngineType, IPhysicalPlayableObject target)
+    {
+        return !requestedEngineType.HasValue || target.Game.Type.ToEngineType() == requestedEngineType;
+    }
 }

test/ModVerify.CliApp.Test/CommonTestBase.cs

@@ -1,8 +1,11 @@
-using System;
-using System.IO.Abstractions;
+using AET.SteamAbstraction;
 using AnakinRaW.CommonUtilities.Hashing;
 using Microsoft.Extensions.DependencyInjection;
 using PG.Commons;
+using PG.StarWarsGame.Infrastructure;
+using PG.StarWarsGame.Infrastructure.Clients.Steam;
+using System;
+using System.IO.Abstractions;
 using Testably.Abstractions.Testing;
 
 namespace ModVerify.CliApp.Test;
@@ -18,6 +21,9 @@ protected CommonTestBase()
         sc.AddSingleton<IHashingService>(sp => new HashingService(sp));
         sc.AddSingleton<IFileSystem>(FileSystem);
         PetroglyphCommons.ContributeServices(sc);
+        PetroglyphGameInfrastructure.InitializeServices(sc);
+        SteamAbstractionLayer.InitializeServices(sc);
+        SteamPetroglyphStarWarsGameClients.InitializeServices(sc);
         // ReSharper disable once VirtualMemberCallInConstructor
         SetupServices(sc);
         ServiceProvider = sc.BuildServiceProvider();

test/ModVerify.CliApp.Test/TargetSelectors/AutomaticSelectorTest.cs

@@ -0,0 +1,77 @@
+namespace ModVerify.CliApp.Test.TargetSelectors;
+
+public class AutomaticSelectorTest : CommonTestBase
+{
+    //private readonly AutomaticSelector _selector;
+    //private readonly IRegistry _registry = new InMemoryRegistry(InMemoryRegistryCreationFlags.WindowsLike);
+
+    //public AutomaticSelectorTest()
+    //{
+    //    _selector = new AutomaticSelector(ServiceProvider);
+    //}
+
+    //protected override void SetupServices(ServiceCollection serviceCollection)
+    //{
+    //    base.SetupServices(serviceCollection);
+    //    serviceCollection.AddSingleton(_registry);
+    //}
+
+    //[Fact]
+    //public void Test_Select_GameNotInstalled()
+    //{
+    //    var settings = new VerificationTargetSettings
+    //    {
+    //        TargetPath = "/test",
+    //    };
+
+    //    Assert.Throws<GameNotFoundException>(() => _selector.SelectTarget(settings));
+    //}
+
+    //[Theory]
+    //[MemberData(nameof(GITestUtilities.RealGameIdentities), MemberType = typeof(GITestUtilities))]
+    //public void Test_Select_Game(GameIdentity identity)
+    //{
+    //    var (eaw, foc) = InstallGames(identity.Platform);
+    //    var game = identity.Type switch
+    //    {
+    //        GameType.Eaw => eaw,
+    //        GameType.Foc => foc,
+    //        _ => throw new ArgumentOutOfRangeException()
+    //    };
+
+    //    var settings = new VerificationTargetSettings
+    //    {
+    //        TargetPath = game.Directory.FullName,
+    //    };
+
+    //    var result = _selector.SelectTarget(settings);
+    //    Assert.Equal(identity.Type, result.Engine.FromEngineType());
+    //    Assert.Equal(game, result.Target);
+    //    Assert.Equal(game.Directory.FullName, result.Locations.GamePath);
+    //}
+
+    //private (IGame eaw, IGame foc) InstallGames(GamePlatform platform)
+    //{
+    //    var eaw = FileSystem.InstallGame(new GameIdentity(GameType.Eaw, platform), ServiceProvider);
+    //    var foc = FileSystem.InstallGame(new GameIdentity(GameType.Eaw, platform), ServiceProvider);
+
+
+
+    //    if (platform == GamePlatform.SteamGold)
+    //    {
+    //        InstallSteam(eaw, foc);
+    //    }
+
+    //    return (eaw, foc);
+    //}
+
+    //private void InstallSteam(IGame eaw, IGame foc)
+    //{
+    //    var registry = ServiceProvider.GetRequiredService<ISteamRegistryFactory>().CreateRegistry();
+    //    FileSystem.InstallSteam(registry);
+
+    //    // Register Game to Steam
+    //    var lib = FileSystem.InstallDefaultLibrary(ServiceProvider);
+    //    lib.InstallGame(32470, "Star Wars Empire at War", [32472], SteamAppState.StateFullyInstalled);
+    //}
+}