Handle "none" GUI textures and unify repo lookups

Refactored texture existence checks by introducing IsNone and GuiSpecialTextureExists helpers. Special cases for "none" textures now avoid false warnings and are consistently cached. Centralized repository lookup logic for Scanlines, ButtonMiddle, and FrameBackground types. Improved error messages by clarifying origin labeling and adjusting error context.

Author: AnakinRaW

src/ModVerify/Verifiers/GuiDialogs/GuiDialogsVerifier.cs

@@ -119,7 +119,11 @@ private void VerifyGuiComponentTexturesExist(string component)
                         componentType is not GuiComponentType.ButtonMiddle &&
                         componentType is not GuiComponentType.Scanlines &&
                         componentType is not GuiComponentType.FrameBackground)
+                    {
+                        if (!cached.Value.AssetExists) 
+                            AddNotFoundError(texture, component, null);
                         continue;
+                    }
                 }
 
                 var exists = GameEngine.GuiDialogManager.TextureExists(
@@ -141,8 +145,9 @@ componentType is not GuiComponentType.Scanlines &&
                         AddNotFoundError(texture, component, origin);
                     }
                 }
-                
-                _cache?.TryAddEntry(texture.Texture, exists);
+
+                // If the texture is "none" we store it as "asset exists" in order to reduce false warnings
+                _cache?.TryAddEntry(texture.Texture, exists || isNone);
             }
             finally
             {
@@ -155,16 +160,18 @@ componentType is not GuiComponentType.Scanlines &&
     private void AddNotFoundError(ComponentTextureEntry texture, string component, GuiTextureOrigin? origin)
     {
         var sb = new StringBuilder($"Could not find GUI texture '{texture.Texture}'");
-        if (origin is not null)
-            sb.Append($" at location '{origin}'");
+        if (origin is not null) 
+            sb.Append($" at origin '{origin}'");
+        sb.Append($" for component '{component}'");
         sb.Append('.');
 
         if (texture.Texture.Length > PGConstants.MaxMegEntryPathLength)
             sb.Append(" The file name is too long.");
 
         AddError(VerificationError.Create(this, VerifierErrorCodes.FileNotFound,
-            sb.ToString(), VerificationSeverity.Error,
-            [component, origin.ToString()], texture.Texture));
+            sb.ToString(), VerificationSeverity.Error, 
+            [component], // Origin is not interesting for context, but might be for the error message
+            texture.Texture));
     }
 
     private IReadOnlyDictionary<GuiComponentType, ComponentTextureEntry> GetTextureEntriesForComponents(string component, out bool defined)

src/PetroglyphTools/PG.StarWarsGame.Engine/GuiDialog/GuiDialogGameManager.cs

@@ -116,50 +116,39 @@ public bool TryGetTextureEntry(string component, GuiComponentType key, out Compo
 
         return textures.TryGetValue(key, out texture);
     }
-    
+
+    private static bool IsNone(string texture)
+    {
+        return texture.Equals("none", StringComparison.OrdinalIgnoreCase);
+    }
+
     public bool TextureExists(
         in ComponentTextureEntry textureInfo,
         out GuiTextureOrigin textureOrigin,
         out bool isNone,
         bool buttonMiddleInRepoMode = false)
     {
-        if (textureInfo.Texture == "none")
-        {
-            textureOrigin = default;
-            isNone = true;
-            return false;
-        }
-
         isNone = false;
-
-        // Apparently, Scanlines only use the repository and not the MTD.
+        
+        // Scanlines use the repository and not the MTD.
         if (textureInfo.ComponentType == GuiComponentType.Scanlines)
-        {
-            textureOrigin = GuiTextureOrigin.Repository;
-            return GameRepository.TextureRepository.FileExists(textureInfo.Texture);
-        }
+            return GuiSpecialTextureExists(textureInfo, out textureOrigin, out isNone);
 
         // The engine uses ButtonMiddle to switch to the special button mode.
         // It searches first in the repo and then falls back to MTD
         // (but only for this very type; the variants do not fallback to MTD).
         if (textureInfo.ComponentType == GuiComponentType.ButtonMiddle)
         {
-            if (GameRepository.TextureRepository.FileExists(textureInfo.Texture))
-            {
-                textureOrigin = GuiTextureOrigin.Repository;
+            if (GuiSpecialTextureExists(textureInfo, out textureOrigin, out isNone))
                 return true;
-            }
         }
 
         // The engine does not fallback to MTD once it is in this special Button mode.
         if (buttonMiddleInRepoMode && textureInfo.ComponentType is 
                 GuiComponentType.ButtonMiddleDisabled or
                 GuiComponentType.ButtonMiddleMouseOver or 
                 GuiComponentType.ButtonMiddlePressed)
-        {
-            textureOrigin = GuiTextureOrigin.Repository;
-            return GameRepository.TextureRepository.FileExists(textureInfo.Texture);
-        }
+            return GuiSpecialTextureExists(textureInfo, out textureOrigin, out isNone);
 
         if (textureInfo.Texture.Length <= 63 && MtdFile is not null && _megaTextureExists)
         {
@@ -173,12 +162,25 @@ GuiComponentType.ButtonMiddleMouseOver or
 
         // The background image for frames include a fallback the repository.
         if (textureInfo.ComponentType == GuiComponentType.FrameBackground)
-        {
-            textureOrigin = GuiTextureOrigin.Repository;
-            return GameRepository.TextureRepository.FileExists(textureInfo.Texture);
-        }
+            return GuiSpecialTextureExists(textureInfo, out textureOrigin, out isNone);
 
         textureOrigin = default;
         return false;
     }
+
+    private bool GuiSpecialTextureExists(
+        in ComponentTextureEntry textureInfo,
+        out GuiTextureOrigin textureOrigin,
+        out bool isNone)
+    {
+        isNone = IsNone(textureInfo.Texture);
+        if (isNone)
+        {
+            textureOrigin = default;
+            return false;
+        }
+
+        textureOrigin = GuiTextureOrigin.Repository;
+        return GameRepository.TextureRepository.FileExists(textureInfo.Texture);
+    }
 }