verify entity name length

Author: AnakinRaW

src/ModVerify/Verifiers/CommandBar/CommandBarVerifier.SingleComponent.cs

@@ -1,4 +1,5 @@
 using AET.ModVerify.Reporting;
+using PG.StarWarsGame.Engine;
 using PG.StarWarsGame.Engine.CommandBar.Components;
 using System;
 using System.Threading;
@@ -9,12 +10,24 @@ partial class CommandBarVerifier
 { 
     private void VerifySingleComponent(CommandBarBaseComponent component, CancellationToken token)
     {
+        VerifyName(component);
         VerifyCommandBarModel(component, token);
         VerifyComponentBone(component);
 
         // TODO: Textures
     }
 
+    private void VerifyName(CommandBarBaseComponent component)
+    {
+        if (component.Name.Length > PGConstants.MaxCommandBarComponentNameBuffer)
+        {
+            AddError(VerificationError.Create(this, VerifierErrorCodes.NameTooLong, 
+                // Deliberately not reporting the buffer length as max, as it's considered to be internal data
+                $"The CommandBarShellComponent name '{component.Name}' is too long. Maximum length is {PGConstants.MaxCommandBarComponentName}.",
+                VerificationSeverity.Critical, [], component.Name));
+        }
+    }
+
     private void VerifyCommandBarModel(CommandBarBaseComponent component, CancellationToken token)
     {
         if (component is not CommandBarShellComponent shellComponent)

src/ModVerify/Verifiers/GameObjects/GameObjectTypeVerifier.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Threading;
+using AET.ModVerify.Reporting;
 using AET.ModVerify.Settings;
 using AET.ModVerify.Verifiers.Commons;
 using PG.StarWarsGame.Engine;
@@ -29,6 +30,12 @@ public GameObjectTypeVerifier(
 
     protected override void VerifyEntity(GameObject entity, string[] context, double progress, CancellationToken token)
     {
+        if (entity.Name.Length >= PGConstants.MaxGameObjectTypeName)
+        {
+            AddError(VerificationError.Create(this, VerifierErrorCodes.NameTooLong,
+                $"The GameObjectType name '{entity.Name}' is too long. Maximum length is {PGConstants.MaxGameObjectTypeName}.", 
+                VerificationSeverity.Critical, entity.Name));
+        }
         VerifyXRefs(entity, context);
         VerifyModels(entity, context, token);
         VerifyIcons(entity, context);

src/ModVerify/Verifiers/SfxEvents/SfxEventVerifier.cs

@@ -1,14 +1,15 @@
-using AET.ModVerify.Settings;
+using AET.ModVerify.Reporting;
+using AET.ModVerify.Settings;
 using AET.ModVerify.Verifiers.Commons;
 using AnakinRaW.CommonUtilities.FileSystem.Normalization;
 using Microsoft.Extensions.DependencyInjection;
 using PG.StarWarsGame.Engine;
+using PG.StarWarsGame.Engine.Audio.Sfx;
 using PG.StarWarsGame.Engine.Localization;
 using System;
 using System.Collections.Generic;
 using System.IO.Abstractions;
 using System.Threading;
-using PG.StarWarsGame.Engine.Audio.Sfx;
 
 namespace AET.ModVerify.Verifiers.SfxEvents;
 
@@ -45,6 +46,12 @@ public SfxEventVerifier(
 
     protected override void VerifyEntity(SfxEvent entity, string[] context, double progress, CancellationToken token)
     {
+        if (entity.Name.Length >= PGConstants.MaxSFXEventName)
+        {
+            AddError(VerificationError.Create(this, VerifierErrorCodes.NameTooLong,
+                $"The SFXEvent name '{entity.Name}' is too long. Maximum length is {PGConstants.MaxSFXEventName}.",
+                VerificationSeverity.Critical, entity.Name));
+        }
         VerifyPresetRef(entity, context);
         VerifySamples(entity, context, token);
     }

src/ModVerify/Verifiers/VerifierErrorCodes.cs

@@ -20,6 +20,8 @@ public static class VerifierErrorCodes
     public const string Duplicate = "DUP00";
     public const string MissingXRef = "XREF00";
 
+    public const string NameTooLong = "NAME00";
+
     public const string MissingPreset = "SFX00";
 
     public const string SampleNotPCM = "WAV00";

src/PetroglyphTools/PG.StarWarsGame.Engine/GameObjects/GameObjectTypeGameManager.cs

@@ -74,4 +74,13 @@ void AddTerrainMappingModels()
             }
         }
     }
+
+    public GameObject? FindObjectType(string? name)
+    {
+        if (string.IsNullOrEmpty(name))
+            return null;
+        var nameCrc = _hashingService.GetCrc32Upper(name, PGConstants.DefaultPGEncoding);
+        NamedEntries.TryGetFirstValue(nameCrc, out var gameObject);
+        return gameObject;
+    }
 }

src/PetroglyphTools/PG.StarWarsGame.Engine/GameObjects/IGameObjectTypeGameManager.cs

@@ -20,4 +20,6 @@ public interface IGameObjectTypeGameManager : IGameManager<GameObject>
     /// An <see cref="IEnumerable{T}"/> containing the names of the models associated with the specified <see cref="GameObject"/>.
     /// </returns>
     IEnumerable<string> GetModels(GameObject gameObject);
+
+    GameObject? FindObjectType(string name);
 }

src/PetroglyphTools/PG.StarWarsGame.Engine/PGConstants.cs

@@ -15,8 +15,11 @@ public static class PGConstants
     public const int MaxSFXEventDatabaseFileName = 259;
     public const int MaxSFXEventName = 255;
     public const int MaxGameObjectDatabaseFileName = 127;
-    public const int MaxCommandBarDatabaseFileName = 259;
+    public const int MaxCommandBarDatabaseFileName = 271;
     public const int MaxCommandBarComponentName = 255;
+    // The actual engine's buffer size that holds name.
+    public const int MaxCommandBarComponentNameBuffer = 263;
+    public const int MaxGameObjectTypeName = 127;
 
     public const int MaxGuiDialogMegaTextureFileName = 255;