GameObjectType PostLoadFixup

Author: AnakinRaW

src/PetroglyphTools/PG.StarWarsGame.Engine/ErrorReporting/EngineAssert.cs

@@ -9,7 +9,7 @@ namespace PG.StarWarsGame.Engine.ErrorReporting;
 
 public sealed class EngineAssert
 {
-    private static readonly string ThisNameSpace = typeof(EngineAssert).Namespace!;
+    private static readonly string ThisNamespace = typeof(EngineAssert).Namespace!;
     private const string NullLiteral = "NULL";
 
     public string Value { get; }
@@ -66,7 +66,7 @@ internal static EngineAssert Create(EngineAssertKind kind, object? value, IEnume
         {
             var frame = trace.GetFrame(i);
             var method = frame.GetMethod();
-            if (method.DeclaringType is null || method.DeclaringType.Namespace?.Equals(ThisNameSpace) == false)
+            if (method.DeclaringType is null || method.DeclaringType.Namespace?.Equals(ThisNamespace) == false)
                 return frame;
         }
         return null;

src/PetroglyphTools/PG.StarWarsGame.Engine/GameObjects/GameObject.cs

@@ -63,16 +63,6 @@ internal GameObject(
         ClassificationName = classification ?? throw new ArgumentNullException(nameof(classification));
         LandTerrainModelMappingValues = new ReadOnlyCollection<(string, string)>(InternalLandTerrainModelMapping);
     }
-    
-    public void PostLoadFixup()
-    {
-        // TODO:
-        // MaxSpeed *= 1.0;
-        // MaxThrust *= 1.0;
-
-        // The engine loads references for scripts, images, hardpoints, etc.,
-        // but we don't do that here.
-    }
 
     internal void ApplyBaseType(GameObject baseType)
     {
@@ -91,4 +81,10 @@ internal void ApplyBaseType(GameObject baseType)
         DamagedSmokeAssetModel = baseType.DamagedSmokeAssetModel;
         InternalLandTerrainModelMapping.ClearAddRange(baseType.InternalLandTerrainModelMapping);
     }
+
+    internal void PostLoadFixup()
+    {
+        // This method is different than the fixup that is performed after parsing the object.
+        // IDK why there are two separate fixups. This fixup performs more value coercions
+    }
 }

src/PetroglyphTools/PG.StarWarsGame.Engine/GameObjects/GameObjectTypeGameManager.Initialization.cs

@@ -1,4 +1,5 @@
-using Microsoft.Extensions.Logging;
+using System;
+using Microsoft.Extensions.Logging;
 using PG.StarWarsGame.Engine.ErrorReporting;
 using PG.StarWarsGame.Engine.Xml;
 using PG.StarWarsGame.Engine.Xml.Parsers;
@@ -70,13 +71,39 @@ private void ParseGameObjectDatabases()
             }
 
 
-
-            //GameObjectTypeClass::Static_Post_Load_Fixup();
+            PostLoadFixup();
             //SFXEventReferenceClass::Static_Post_Load_Fixup();
             //SpeechEventReferenceClass::Static_Post_Load_Fixup();
             //MusicEventReferenceClass::Static_Post_Load_Fixup();
             //FactionReferenceClass::Static_Post_Load_Fixup();
             //...
+
+            allLoaded = true;
+
+            foreach (var gameObject in _gameObjects)
+            {
+                gameObject.PostLoadFixup();
+                if (!gameObject.IsLoadingComplete) 
+                    allLoaded = false;
+            }
+        }
+    }
+
+    private void PostLoadFixup()
+    {
+        // In the engine, this is the so-called static post load fixup.
+        foreach (var gameObject in _gameObjects)
+        {
+            var baseTypeName = gameObject.VariantOfExistingTypeName;
+            if (string.IsNullOrEmpty(baseTypeName) || baseTypeName.Equals("None", StringComparison.OrdinalIgnoreCase))
+                continue;
+
+            // At this point the engine would assert, if the base type was not found.
+            // We do not, because the game reports this error for every iteration of the loading loop,
+            // which would bloat error logs.
+            var baseNameHash = _hashingService.GetCrc32Upper(baseTypeName, PGConstants.DefaultPGEncoding);
+            NamedEntries.TryGetFirstValue(baseNameHash, out var baseType);
+            gameObject.VariantOfExistingType = baseType;
         }
     }
 

src/PetroglyphTools/PG.StarWarsGame.Engine/GameObjects/GameObjectTypeGameManager.cs

@@ -1,21 +1,25 @@
-using PG.StarWarsGame.Engine.ErrorReporting;
+using PG.Commons.Hashing;
+using PG.StarWarsGame.Engine.ErrorReporting;
 using PG.StarWarsGame.Engine.IO.Repositories;
 using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
+using Microsoft.Extensions.DependencyInjection;
 
 namespace PG.StarWarsGame.Engine.GameObjects;
 
 internal partial class GameObjectTypeGameManager : GameManagerBase<GameObject>, IGameObjectTypeGameManager
 {
     private readonly List<GameObject> _gameObjects;
+    private readonly ICrc32HashingService _hashingService;
 
     public GameObjectTypeGameManager(
         GameRepository repository, 
         GameEngineErrorReporterWrapper errorReporter, 
         IServiceProvider serviceProvider)
         : base(repository, errorReporter, serviceProvider)
     {
+        _hashingService = serviceProvider.GetRequiredService<ICrc32HashingService>();
         _gameObjects = [];
         GameObjects = new ReadOnlyCollection<GameObject>(_gameObjects);
     }

src/PetroglyphTools/PG.StarWarsGame.Engine/Xml/Parsers/NamedObjects/GameObjectParser.cs

@@ -75,10 +75,11 @@ protected override void ValidateAndFixupValues(GameObject gameObject, XElement e
     {
         if (!OverlayLoad)
         {
+            // TODO
             //BehaviorClass.AddImpliedBehaviors(this, BehaviorNames);
             //InitBehaviorMap();
 
-            gameObject.PostLoadFixup();
+            PostLoadFixup(gameObject);
             if (string.IsNullOrEmpty(gameObject.VariantOfExistingTypeName))
                 gameObject.IsLoadingComplete = true;
             else
@@ -113,7 +114,7 @@ private void OverlayType(GameObject baseType, GameObject derivedType, XElement e
 
         ParseTags(derivedType, element, true, ReadOnlyFrugalValueListDictionary<Crc32, GameObject>.Empty);
 
-        derivedType.PostLoadFixup();
+        PostLoadFixup(derivedType);
         derivedType.IsLoadingComplete = true;
     }
 
@@ -130,6 +131,17 @@ protected override bool ParseTag(
         return true;
     }
 
+    private void PostLoadFixup(GameObject gameObject)
+    {
+        // TODO:
+        // MaxSpeed *= 1.0;
+        // MaxThrust *= 1.0;
+        // Asserts and some coercions
+
+        // The engine loads references for scripts, images, hardpoints, etc.,
+        // but we don't do that here.
+    }
+
     private sealed class GameObjectXmlTagMapper(IServiceProvider serviceProvider) : XmlTagMapper<GameObject>(serviceProvider)
     {
         protected override void BuildMappings()