rename to baseDirectory

Author: AnakinRaW

src/PetroglyphTools/PG.StarWarsGame.Engine.FileSystem/IO/FileExistStrategies/FileExistsStrategy.cs

@@ -8,7 +8,7 @@ internal abstract class FileExistsStrategy(IFileSystem fileSystem) : IDisposable
 {
     protected readonly IFileSystem FileSystem = fileSystem;
 
-    public abstract bool FileExists(ReadOnlySpan<char> gameDirectory, ref ValueStringBuilder stringBuilder);
+    public abstract bool FileExists(ReadOnlySpan<char> baseDirectory, ref ValueStringBuilder stringBuilder);
 
     public virtual void Dispose() { }
 }

src/PetroglyphTools/PG.StarWarsGame.Engine.FileSystem/IO/FileExistStrategies/VirtualFileExistsStrategy.cs

@@ -20,21 +20,21 @@ public override void Dispose()
         underlying.Dispose();
     }
 
-    public override bool FileExists(ReadOnlySpan<char> gameDirectory, ref ValueStringBuilder stringBuilder)
+    public override bool FileExists(ReadOnlySpan<char> baseDirectory, ref ValueStringBuilder stringBuilder)
     {
         var filePath = stringBuilder.AsSpan();
 
-        if (!IsUnderGameDirectory(filePath, gameDirectory))
-            return underlying.FileExists(gameDirectory, ref stringBuilder);
+        if (!IsUnderBaseDirectory(filePath, baseDirectory))
+            return underlying.FileExists(baseDirectory, ref stringBuilder);
 
         var lastSep = filePath.LastIndexOf(Path.DirectorySeparatorChar);
         if (lastSep <= 0)
-            return underlying.FileExists(gameDirectory, ref stringBuilder);
+            return underlying.FileExists(baseDirectory, ref stringBuilder);
 
         var dirSpan = filePath.Slice(0, lastSep);
         var fileName = filePath.Slice(lastSep + 1);
         if (fileName.IsEmpty)
-            return underlying.FileExists(gameDirectory, ref stringBuilder);
+            return underlying.FileExists(baseDirectory, ref stringBuilder);
 
         var dirKey = dirSpan.ToString();
         if (!_store.TryGetValue(dirKey, out var virtualDir))
@@ -155,7 +155,7 @@ public override bool FileExists(ReadOnlySpan<char> gameDirectory, ref ValueStrin
         }
     }
 
-    private bool IsUnderGameDirectory(ReadOnlySpan<char> path, ReadOnlySpan<char> gameDirectory)
+    private bool IsUnderBaseDirectory(ReadOnlySpan<char> path, ReadOnlySpan<char> gameDirectory)
     {
         return !gameDirectory.IsEmpty && FileSystem.Path.IsChildOf(gameDirectory, path);
     }

src/PetroglyphTools/PG.StarWarsGame.Engine.FileSystem/IO/FileExistStrategies/WindowsFileExistsStrategy.cs

@@ -14,7 +14,7 @@ namespace PG.StarWarsGame.Engine.IO.FileExistStrategies;
 /// </summary>
 internal sealed class WindowsFileExistsStrategy(IFileSystem fileSystem) : FileExistsStrategy(fileSystem)
 {
-    public override bool FileExists(ReadOnlySpan<char> gameDirectory, ref ValueStringBuilder stringBuilder)
+    public override bool FileExists(ReadOnlySpan<char> baseDirectory, ref ValueStringBuilder stringBuilder)
     {
         // We *could* also use the slightly faster GetFileAttributesA. However, CreateFileA and
         // GetFileAttributesA are implemented entirely independently in Windows; the game uses

src/PetroglyphTools/PG.StarWarsGame.Engine.FileSystem/IO/FileExistStrategies/WineFileExistsStrategy.cs

@@ -10,7 +10,7 @@ namespace PG.StarWarsGame.Engine.IO.FileExistStrategies;
 
 internal sealed class WineFileExistsStrategy(IFileSystem fileSystem) : FileExistsStrategy(fileSystem)
 {
-    public override bool FileExists(ReadOnlySpan<char> gameDirectory, ref ValueStringBuilder stringBuilder)
+    public override bool FileExists(ReadOnlySpan<char> baseDirectory, ref ValueStringBuilder stringBuilder)
     {
         var pathString = stringBuilder.AsSpan().ToString();
         if (pathString.Length == 0)
@@ -35,17 +35,17 @@ public override bool FileExists(ReadOnlySpan<char> gameDirectory, ref ValueStrin
             return false;
         var parentDirInput = pathString.Substring(0, parentLen);
 
-        var resolvedParent = ResolveDirectory(parentDirInput, gameDirectory, rootLen);
+        var resolvedParent = ResolveDirectory(parentDirInput, baseDirectory, rootLen);
         if (resolvedParent is null)
             return false;
 
         return ResolveLeafIn(resolvedParent, fileName, ref stringBuilder);
     }
 
-    private string? ResolveDirectory(string dirInput, ReadOnlySpan<char> gameDirectory, int rootLen)
+    private string? ResolveDirectory(string dirInput, ReadOnlySpan<char> baseDirectory, int rootLen)
     {
         var path = dirInput.AsSpan();
-        var knownGoodPrefixLength = LowLevelPath.GetCommonDirectoryPrefixLength(path, gameDirectory);
+        var knownGoodPrefixLength = LowLevelPath.GetCommonDirectoryPrefixLength(path, baseDirectory);
 
         int prefixEnd;
         if (knownGoodPrefixLength > rootLen)

src/PetroglyphTools/PG.StarWarsGame.Engine.FileSystem/IO/PetroglyphFileSystem.Exist.cs

@@ -9,12 +9,12 @@ namespace PG.StarWarsGame.Engine.IO;
 public sealed partial class PetroglyphFileSystem
 {
     /// <summary>
-    /// Resolves <paramref name="filePath"/> against <paramref name="gameDirectory"/>, normalizes
+    /// Resolves <paramref name="filePath"/> against <paramref name="baseDirectory"/>, normalizes
     /// the path, and dispatches the lookup to the active <c>FileExists</c> strategy.
     /// </summary>
     /// <remarks>
     /// Fully-qualified inputs are taken as-is; relative inputs are joined to
-    /// <paramref name="gameDirectory"/> first. The buffer is then unified to the host's native
+    /// <paramref name="baseDirectory"/> first. The buffer is then unified to the host's native
     /// directory separator and dot segments (<c>.</c> and <c>..</c>) are resolved, after which
     /// the active strategy answers the lookup. On <see langword="true" /> the buffer contains
     /// the resolved on-disk path; on <see langword="false" /> the buffer content is unspecified.
@@ -24,28 +24,28 @@ public sealed partial class PetroglyphFileSystem
     /// A scratch buffer used to build and return the resolved path. The caller owns the buffer's
     /// lifetime and is responsible for disposing it.
     /// </param>
-    /// <param name="gameDirectory">
-    /// The game directory used as the base when <paramref name="filePath"/> is relative.
+    /// <param name="baseDirectory">
+    /// The base directory used as the base when <paramref name="filePath"/> is relative.
     /// </param>
     /// <returns>
     /// <see langword="true" /> if the file exists; otherwise, <see langword="false" />.
     /// </returns>
-    internal bool FileExists(ReadOnlySpan<char> filePath, ref ValueStringBuilder stringBuilder, ReadOnlySpan<char> gameDirectory)
+    internal bool FileExists(ReadOnlySpan<char> filePath, ref ValueStringBuilder stringBuilder, ReadOnlySpan<char> baseDirectory)
     {
         stringBuilder.Length = 0;
 
         if (IsPathFullyQualified_Exists(filePath))
             stringBuilder.Append(filePath);
         else
-            JoinPath(gameDirectory, filePath, ref stringBuilder);
+            JoinPath(baseDirectory, filePath, ref stringBuilder);
 
         // Canonicalize once for every strategy: unify separators to the host's native form, then
         // strip "." / ".." and trailing/duplicated separators. After this the buffer is ready to
         // hand directly to host FS APIs.
         NormalizePath(ref stringBuilder);
         NormalizeDotSegmentsInPlace(ref stringBuilder);
 
-        return _strategy.FileExists(gameDirectory, ref stringBuilder);
+        return _strategy.FileExists(baseDirectory, ref stringBuilder);
     }
 
     internal void NormalizeDotSegmentsInPlace(ref ValueStringBuilder sb)