use different FS strategies on verify and create baseline

Author: AnakinRaW

src/ModVerify.CliApp/Settings/SettingsBuilder.cs

@@ -36,13 +36,14 @@ private AppVerifySettings BuildFromVerifyVerb(VerifyVerbOption verifyOptions)
                 ParallelVerifiers = verifyOptions.Parallel ? 4 : 1,
                 VerifiersProvider = new DefaultGameVerifiersProvider(),
                 FailFastSettings = failFastSetting,
+                UseLiveVirtualFileSystem = true,
                 GameVerifySettings = new GameVerifySettings
                 {
                     IgnoreAsserts = verifyOptions.IgnoreAsserts,
-                    ThrowsOnMinimumSeverity = failFastSetting.IsFailFast 
+                    ThrowsOnMinimumSeverity = failFastSetting.IsFailFast
                         ? failFastSetting.MinumumSeverity
                         // The app shall not make a specific verifier throw, but it should always run to completion.
-                        : null 
+                        : null
                 }
             },
             AppFailsOnMinimumSeverity = verifyOptions.MinimumFailureSeverity,

src/ModVerify/GameVerifyPipeline.cs

@@ -18,6 +18,7 @@
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using PG.StarWarsGame.Engine;
+using PG.StarWarsGame.Engine.IO;
 
 namespace AET.ModVerify;
 
@@ -83,14 +84,18 @@ protected override async Task PrepareCoreAsync(CancellationToken token)
         try
         {
             var engineService = ServiceProvider.GetRequiredService<IPetroglyphStarWarsGameEngineService>();
+            Action<PetroglyphFileSystem>? configureFs = _serviceSettings.UseLiveVirtualFileSystem
+                ? static fs => fs.UseLiveVirtualStrategy()
+                : null;
+
             _gameEngine = await engineService.InitializeAsync(
                 _verificationTarget.Engine,
                 _verificationTarget.Location,
                 _engineErrorReporter,
                 _engineInitializationReporter,
                 false,
-                configureFileSystem:fs => fs.UseLiveVirtualStrategy(),
-                cancellationToken: CancellationToken.None).ConfigureAwait(false);
+                configureFs,
+                CancellationToken.None).ConfigureAwait(false);
         }
         catch (Exception e)
         {

src/ModVerify/Settings/VerifierServiceSettings.cs

@@ -9,4 +9,6 @@ public sealed class VerifierServiceSettings
     public FailFastSetting FailFastSettings { get; init; } = FailFastSetting.NoFailFast;
 
     public int ParallelVerifiers { get; init; } = 4;
+
+    public bool UseLiveVirtualFileSystem { get; init; } = false;
 }

test/ModVerify.CliApp.Test/SettingsBuilderTest.cs

@@ -107,4 +107,20 @@ public void BuildSettings_UseDefaultBaseline_Alone_DoesNotThrow()
         var settings = _builder.BuildSettings(options);
         Assert.NotNull(settings);
     }
+
+    [Fact]
+    public void BuildSettings_VerifyVerb_UsesLiveVirtualFileSystem()
+    {
+        var options = new VerifyVerbOption { TargetPath = "myPath" };
+        var settings = (AppVerifySettings)_builder.BuildSettings(options);
+        Assert.True(settings.VerifierServiceSettings.UseLiveVirtualFileSystem);
+    }
+
+    [Fact]
+    public void BuildSettings_CreateBaselineVerb_DoesNotUseLiveVirtualFileSystem()
+    {
+        var options = new CreateBaselineVerbOption { TargetPath = "myPath", OutputFile = "out.json" };
+        var settings = (AppBaselineSettings)_builder.BuildSettings(options);
+        Assert.False(settings.VerifierServiceSettings.UseLiveVirtualFileSystem);
+    }
 }