parallel runs are not supported for baselines

Author: AnakinRaW

src/ModVerify.CliApp/Settings/CommandLine/BaseModVerifyOptions.cs

@@ -1,5 +1,4 @@
-using System.Collections.Generic;
-using AET.ModVerify.Reporting;
+using AET.ModVerify.Reporting;
 using CommandLine;
 using PG.StarWarsGame.Engine;
 
@@ -52,12 +51,6 @@ internal abstract class BaseModVerifyOptions
                    "Multiple paths can be separated using the platform-specific path separator (';' on Windows, ':' on Linux).")]
     public string? AdditionalFallbackPath { get; init; }
 
-    // TODO: Should not be supported for creating baselines, because we want deterministic baselines.
-    [Option("parallel", Default = false,
-        HelpText = "When set, game verifiers will run in parallel. " +
-                   "While this may reduce analysis time, console output might be harder to read.")]
-    public bool Parallel { get; init; }
-
     [Option("baseline", Required = false,
         HelpText = "Path(s) to one or more JSON baseline files. Multiple paths can be separated using the platform-specific path separator (';' on Windows, ':' on Linux). " +
                    "For 'verify' this is mutually exclusive with --searchBaseline. May be combined with --useDefaultBaseline.")]

src/ModVerify.CliApp/Settings/CommandLine/VerifyVerbOption.cs

@@ -27,5 +27,10 @@ internal sealed class VerifyVerbOption : BaseModVerifyOptions
         HelpText = "When this flag is present, the application will not report engine assertions.")]
     public bool IgnoreAsserts { get; init; }
 
+    [Option("parallel", Default = false,
+        HelpText = "When set, game verifiers will run in parallel. " +
+                   "While this may reduce analysis time, console output might be harder to read.")]
+    public bool Parallel { get; init; }
+
     public bool IsRunningWithoutArguments { get; init; }
 }

src/ModVerify.CliApp/Settings/SettingsBuilder.cs

@@ -92,7 +92,9 @@ private AppBaselineSettings BuildFromCreateBaselineVerb(CreateBaselineVerbOption
         {
             VerifierServiceSettings = new VerifierServiceSettings
             {
-                ParallelVerifiers = baselineVerb.Parallel ? 4 : 1,
+                // Always sequential: baseline creation must be deterministic — error ordering
+                // and any other parallelism-sensitive behavior would otherwise vary between runs.
+                ParallelVerifiers = 1,
                 VerifiersProvider = new DefaultGameVerifiersProvider(),
                 GameVerifySettings = GameVerifySettings.Default,
                 FailFastSettings = FailFastSetting.NoFailFast,