new names

Author: AnakinRaW

src/ModVerify/Reporting/Diagnostics/Diagnostics.Audio.cs

@@ -4,7 +4,7 @@
 namespace AET.ModVerify.Reporting.Diagnostics;
 
 /// <summary>Provides factories for findings produced while verifying audio sample files.</summary>
-public static class Audio
+public static class AudioErrors
 {
     private static readonly ErrorDescriptor _fileNotFound = new(
         VerifierErrorCodes.FileNotFound, "AudioFileNotFound", VerificationSeverity.Error, "Audio");

src/ModVerify/Reporting/Diagnostics/Diagnostics.CommandBar.cs

@@ -4,7 +4,7 @@
 namespace AET.ModVerify.Reporting.Diagnostics;
 
 /// <summary>Provides factories for findings produced while verifying the command bar.</summary>
-public static class CommandBar
+public static class CommandBarErrors
 {
     private const string GameCommandBarAsset = "GameCommandBar";
 

src/ModVerify/Reporting/Diagnostics/Diagnostics.Common.cs

@@ -4,7 +4,7 @@
 namespace AET.ModVerify.Reporting.Diagnostics;
 
 /// <summary>Provides factories for findings that are not specific to a single verifier family.</summary>
-public static class Common
+public static class CommonErrors
 {
     private static readonly ErrorDescriptor _duplicate = new(
         VerifierErrorCodes.Duplicate, "DuplicateEntry", VerificationSeverity.Error, "Common");

src/ModVerify/Reporting/Diagnostics/Diagnostics.Engine.cs

@@ -4,15 +4,15 @@
 namespace AET.ModVerify.Reporting.Diagnostics;
 
 /// <summary>Provides the engine-initialization descriptor read by the engine reporter.</summary>
-public static class Engine
+public static class EngineErrors
 {
     /// <summary>The game engine reported an error during initialization. The message is supplied by the engine.</summary>
     public static readonly ErrorDescriptor InitializationError = new(
         VerifierErrorCodes.InitializationError, "EngineInitializationError", VerificationSeverity.Critical, "Engine");
 }
 
 /// <summary>Provides factories for hard-coded engine assets that are loaded at startup.</summary>
-public static class HardcodedAssets
+public static class HardcodedAssetErrors
 {
     private static readonly ErrorDescriptor _shaderNotFound = new(
         VerifierErrorCodes.FileNotFound, "HardcodedShaderNotFound", VerificationSeverity.Error, "HardcodedAssets");
@@ -31,71 +31,8 @@ public static VerificationError TerrainShaderNotFound(IGameVerifierInfo verifier
         => _terrainShaderNotFound.Create(verifier, $"Unable to find terrain shader '{shaderName}'.", shaderName, context);
 }
 
-// Descriptors for findings produced by the engine-side reporters. Their messages are supplied by the engine
-// (XML parser, asserts), so the reporters read only Id and Severity.
-
-/// <summary>Provides descriptors for findings reported by the engine's XML parser.</summary>
-public static class Xml
-{
-    /// <summary>The XML parser reported an error that does not map to a more specific kind.</summary>
-    public static readonly ErrorDescriptor Generic = new(
-        VerifierErrorCodes.GenericXmlError, "XmlGenericError", VerificationSeverity.Warning, "Xml");
-
-    /// <summary>An XML file has an empty root element.</summary>
-    public static readonly ErrorDescriptor EmptyRoot = new(
-        VerifierErrorCodes.EmptyXmlRoot, "XmlEmptyRoot", VerificationSeverity.Critical, "Xml");
-
-    /// <summary>An XML file referenced by the parser could not be found.</summary>
-    public static readonly ErrorDescriptor MissingFile = new(
-        VerifierErrorCodes.FileNotFound, "XmlMissingFile", VerificationSeverity.Error, "Xml");
-
-    /// <summary>An XML element has an invalid value.</summary>
-    public static readonly ErrorDescriptor InvalidValue = new(
-        VerifierErrorCodes.InvalidXmlValue, "XmlInvalidValue", VerificationSeverity.Information, "Xml");
-
-    /// <summary>An XML element has a malformed value.</summary>
-    public static readonly ErrorDescriptor MalformedValue = new(
-        VerifierErrorCodes.MalformedXmlValue, "XmlMalformedValue", VerificationSeverity.Warning, "Xml");
-
-    /// <summary>An XML element is missing a required attribute.</summary>
-    public static readonly ErrorDescriptor MissingAttribute = new(
-        VerifierErrorCodes.MissingXmlAttribute, "XmlMissingAttribute", VerificationSeverity.Error, "Xml");
-
-    /// <summary>An XML element references an entry that does not exist.</summary>
-    public static readonly ErrorDescriptor MissingReference = new(
-        VerifierErrorCodes.MissingXmlReference, "XmlMissingReference", VerificationSeverity.Error, "Xml");
-
-    /// <summary>An XML value exceeds the maximum allowed length.</summary>
-    public static readonly ErrorDescriptor ValueTooLong = new(
-        VerifierErrorCodes.XmlValueTooLong, "XmlValueTooLong", VerificationSeverity.Warning, "Xml");
-
-    /// <summary>An XML file contains data before its header.</summary>
-    public static readonly ErrorDescriptor DataBeforeHeader = new(
-        VerifierErrorCodes.XmlDataBeforeHeader, "XmlDataBeforeHeader", VerificationSeverity.Information, "Xml");
-
-    /// <summary>A required XML node is missing.</summary>
-    public static readonly ErrorDescriptor MissingNode = new(
-        VerifierErrorCodes.XmlMissingNode, "XmlMissingNode", VerificationSeverity.Critical, "Xml");
-
-    /// <summary>An XML file contains a node the parser does not support.</summary>
-    public static readonly ErrorDescriptor UnknownNode = new(
-        VerifierErrorCodes.XmlUnsupportedTag, "XmlUnknownNode", VerificationSeverity.Information, "Xml");
-
-    /// <summary>An XML tag unexpectedly contains child elements.</summary>
-    public static readonly ErrorDescriptor TagHasElements = new(
-        VerifierErrorCodes.XmlElementsInTag, "XmlTagHasElements", VerificationSeverity.Warning, "Xml");
-
-    /// <summary>An XML element has a name the parser did not expect.</summary>
-    public static readonly ErrorDescriptor UnexpectedElementName = new(
-        VerifierErrorCodes.XmlUnexceptedElementName, "XmlUnexpectedElementName", VerificationSeverity.Information, "Xml");
-
-    /// <summary>An XML node has an empty name.</summary>
-    public static readonly ErrorDescriptor EmptyNodeName = new(
-        VerifierErrorCodes.XmlEmptyNodeName, "XmlEmptyNodeName", VerificationSeverity.Warning, "Xml");
-}
-
 /// <summary>Provides descriptors for assertions raised by the engine.</summary>
-public static class Asserts
+public static class AssertErrors
 {
     /// <summary>The engine asserted that a value was null or empty.</summary>
     public static readonly ErrorDescriptor NullOrEmptyValue = new(

src/ModVerify/Reporting/Diagnostics/Diagnostics.GameObjects.cs

@@ -4,7 +4,7 @@
 namespace AET.ModVerify.Reporting.Diagnostics;
 
 /// <summary>Provides factories for findings produced while verifying game object types.</summary>
-public static class GameObjects
+public static class GameObjectErrors
 {
     private static readonly ErrorDescriptor _nameTooLong = new(
         VerifierErrorCodes.NameTooLong, "GameObjectNameTooLong", VerificationSeverity.Critical, "GameObjects");

src/ModVerify/Reporting/Diagnostics/Diagnostics.GuiDialogs.cs

@@ -4,7 +4,7 @@
 namespace AET.ModVerify.Reporting.Diagnostics;
 
 /// <summary>Provides factories for findings produced while verifying GUI dialog textures.</summary>
-public static class GuiDialogs
+public static class GuiDialogErrors
 {
     private static readonly ErrorDescriptor _mtdFileNotFound = new(
         VerifierErrorCodes.FileNotFound, "GuiMtdFileNotFound", VerificationSeverity.Critical, "GuiDialogs");

src/ModVerify/Reporting/Diagnostics/Diagnostics.Models.cs

@@ -4,7 +4,7 @@
 namespace AET.ModVerify.Reporting.Diagnostics;
 
 /// <summary>Provides factories for findings produced while verifying models, particles, and animations.</summary>
-public static class Models
+public static class ModelErrors
 {
     private static readonly ErrorDescriptor _alamoFileNotFound = new(
         VerifierErrorCodes.FileNotFound, "AlamoFileNotFound", VerificationSeverity.Error, "Models");
@@ -111,21 +111,3 @@ public static VerificationError ProxyNotFound(IGameVerifierInfo verifier, string
     public static VerificationError ShaderNotFound(IGameVerifierInfo verifier, string shaderEffect, string modelFile, IEnumerable<string> context)
         => _shaderNotFound.Create(verifier, $"Shader effect '{shaderEffect}' not found for model '{modelFile}'.", shaderEffect, context);
 }
-
-/// <summary>Provides factories for findings produced while verifying textures.</summary>
-public static class Textures
-{
-    private static readonly ErrorDescriptor _pathTooLong = new(
-        VerifierErrorCodes.FilePathTooLong, "TexturePathTooLong", VerificationSeverity.Error, "Textures");
-
-    private static readonly ErrorDescriptor _notFound = new(
-        VerifierErrorCodes.FileNotFound, "TextureNotFound", VerificationSeverity.Error, "Textures");
-
-    /// <summary>Creates an error for a texture that could not be found because the resolved path is too long.</summary>
-    public static VerificationError PathTooLong(IGameVerifierInfo verifier, string texturePath, IEnumerable<string> context)
-        => _pathTooLong.Create(verifier, $"Could not find texture '{texturePath}' because the engine resolved a path that is too long.", texturePath, context);
-
-    /// <summary>Creates an error for a texture that could not be found.</summary>
-    public static VerificationError NotFound(IGameVerifierInfo verifier, string texturePath, IEnumerable<string> context)
-        => _notFound.Create(verifier, $"Could not find texture '{texturePath}'.", texturePath, context);
-}

src/ModVerify/Reporting/Diagnostics/Diagnostics.Sfx.cs

@@ -4,7 +4,7 @@
 namespace AET.ModVerify.Reporting.Diagnostics;
 
 /// <summary>Provides factories for findings produced while verifying SFX events.</summary>
-public static class Sfx
+public static class SfxErrors
 {
     private static readonly ErrorDescriptor _nameTooLong = new(
         VerifierErrorCodes.NameTooLong, "SfxEventNameTooLong", VerificationSeverity.Critical, "Sfx");

src/ModVerify/Reporting/Diagnostics/Diagnostics.Textures.cs

@@ -0,0 +1,22 @@
+using System.Collections.Generic;
+using AET.ModVerify.Verifiers;
+
+namespace AET.ModVerify.Reporting.Diagnostics;
+
+/// <summary>Provides factories for findings produced while verifying textures.</summary>
+public static class TextureErrors
+{
+    private static readonly ErrorDescriptor _pathTooLong = new(
+        VerifierErrorCodes.FilePathTooLong, "TexturePathTooLong", VerificationSeverity.Error, "Textures");
+
+    private static readonly ErrorDescriptor _notFound = new(
+        VerifierErrorCodes.FileNotFound, "TextureNotFound", VerificationSeverity.Error, "Textures");
+
+    /// <summary>Creates an error for a texture that could not be found because the resolved path is too long.</summary>
+    public static VerificationError PathTooLong(IGameVerifierInfo verifier, string texturePath, IEnumerable<string> context)
+        => _pathTooLong.Create(verifier, $"Could not find texture '{texturePath}' because the engine resolved a path that is too long.", texturePath, context);
+
+    /// <summary>Creates an error for a texture that could not be found.</summary>
+    public static VerificationError NotFound(IGameVerifierInfo verifier, string texturePath, IEnumerable<string> context)
+        => _notFound.Create(verifier, $"Could not find texture '{texturePath}'.", texturePath, context);
+}

src/ModVerify/Reporting/Diagnostics/Diagnostics.Xml.cs

@@ -0,0 +1,63 @@
+using AET.ModVerify.Verifiers;
+
+namespace AET.ModVerify.Reporting.Diagnostics;
+
+/// <summary>Provides descriptors for findings reported by the engine's XML parser.</summary>
+public static class XmlErrors
+{
+    /// <summary>The XML parser reported an error that does not map to a more specific kind.</summary>
+    public static readonly ErrorDescriptor Generic = new(
+        VerifierErrorCodes.GenericXmlError, "XmlGenericError", VerificationSeverity.Warning, "Xml");
+
+    /// <summary>An XML file has an empty root element.</summary>
+    public static readonly ErrorDescriptor EmptyRoot = new(
+        VerifierErrorCodes.EmptyXmlRoot, "XmlEmptyRoot", VerificationSeverity.Critical, "Xml");
+
+    /// <summary>An XML file referenced by the parser could not be found.</summary>
+    public static readonly ErrorDescriptor MissingFile = new(
+        VerifierErrorCodes.FileNotFound, "XmlMissingFile", VerificationSeverity.Error, "Xml");
+
+    /// <summary>An XML element has an invalid value.</summary>
+    public static readonly ErrorDescriptor InvalidValue = new(
+        VerifierErrorCodes.InvalidXmlValue, "XmlInvalidValue", VerificationSeverity.Information, "Xml");
+
+    /// <summary>An XML element has a malformed value.</summary>
+    public static readonly ErrorDescriptor MalformedValue = new(
+        VerifierErrorCodes.MalformedXmlValue, "XmlMalformedValue", VerificationSeverity.Warning, "Xml");
+
+    /// <summary>An XML element is missing a required attribute.</summary>
+    public static readonly ErrorDescriptor MissingAttribute = new(
+        VerifierErrorCodes.MissingXmlAttribute, "XmlMissingAttribute", VerificationSeverity.Error, "Xml");
+
+    /// <summary>An XML element references an entry that does not exist.</summary>
+    public static readonly ErrorDescriptor MissingReference = new(
+        VerifierErrorCodes.MissingXmlReference, "XmlMissingReference", VerificationSeverity.Error, "Xml");
+
+    /// <summary>An XML value exceeds the maximum allowed length.</summary>
+    public static readonly ErrorDescriptor ValueTooLong = new(
+        VerifierErrorCodes.XmlValueTooLong, "XmlValueTooLong", VerificationSeverity.Warning, "Xml");
+
+    /// <summary>An XML file contains data before its header.</summary>
+    public static readonly ErrorDescriptor DataBeforeHeader = new(
+        VerifierErrorCodes.XmlDataBeforeHeader, "XmlDataBeforeHeader", VerificationSeverity.Information, "Xml");
+
+    /// <summary>A required XML node is missing.</summary>
+    public static readonly ErrorDescriptor MissingNode = new(
+        VerifierErrorCodes.XmlMissingNode, "XmlMissingNode", VerificationSeverity.Critical, "Xml");
+
+    /// <summary>An XML file contains a node the parser does not support.</summary>
+    public static readonly ErrorDescriptor UnknownNode = new(
+        VerifierErrorCodes.XmlUnsupportedTag, "XmlUnknownNode", VerificationSeverity.Information, "Xml");
+
+    /// <summary>An XML tag unexpectedly contains child elements.</summary>
+    public static readonly ErrorDescriptor TagHasElements = new(
+        VerifierErrorCodes.XmlElementsInTag, "XmlTagHasElements", VerificationSeverity.Warning, "Xml");
+
+    /// <summary>An XML element has a name the parser did not expect.</summary>
+    public static readonly ErrorDescriptor UnexpectedElementName = new(
+        VerifierErrorCodes.XmlUnexceptedElementName, "XmlUnexpectedElementName", VerificationSeverity.Information, "Xml");
+
+    /// <summary>An XML node has an empty name.</summary>
+    public static readonly ErrorDescriptor EmptyNodeName = new(
+        VerifierErrorCodes.XmlEmptyNodeName, "XmlEmptyNodeName", VerificationSeverity.Warning, "Xml");
+}