Skip to content

Commit d77f8d3

Browse files
committed
rename method to express intent
1 parent 2078875 commit d77f8d3

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/PetroglyphTools/PG.StarWarsGame.Files.XML/Parsers/Base/PetroglyphXmlFileParserBase.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public abstract class PetroglyphXmlFileParserBase(IServiceProvider serviceProvid
2323

2424
protected XElement GetRootElement(Stream xmlStream, out string fileName)
2525
{
26-
fileName = GetStrippedFileName(xmlStream.GetFilePath());
26+
fileName = GetStrippedFilePath(xmlStream.GetFilePath());
2727

2828
if (string.IsNullOrEmpty(fileName))
2929
throw new InvalidOperationException("Unable to parse XML from unnamed stream. Either parse from a file or MEG stream.");
@@ -62,7 +62,7 @@ protected XElement GetRootElement(Stream xmlStream, out string fileName)
6262
return root;
6363
}
6464

65-
private string GetStrippedFileName(string filePath)
65+
private string GetStrippedFilePath(string filePath)
6666
{
6767
if (!FileSystem.Path.IsPathFullyQualified(filePath))
6868
return filePath;
@@ -77,6 +77,7 @@ private string GetStrippedFileName(string filePath)
7777
[MethodImpl(MethodImplOptions.AggressiveInlining)]
7878
static string GetXmlDataFolder()
7979
{
80+
// Required because we don't have access to the PGFileSystem here.
8081
return RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? @"DATA\XML\" : "DATA/XML/";
8182
}
8283
}

0 commit comments

Comments
 (0)