Remove unused test case for volume file names and update path handling in FileExists test

Author: AnakinRaW

src/PetroglyphTools/PG.StarWarsGame.Engine.FileSystem.Test/IO/PetroglyphFileSystemTests.Exist.cs

@@ -168,15 +168,17 @@ public void IsPathFullyQualified_Exists_Internal(string path, bool expected)
         var vsb = new ValueStringBuilder();
         _pgFileSystem.FileExists(path.AsSpan(), ref vsb, gameDir.AsSpan());
 
-        var resultPath = vsb.ToString();
+        var resultPath = vsb.ToString().Replace('/', Path.DirectorySeparatorChar).Replace('\\', Path.DirectorySeparatorChar);
+        var expectedGameDir = gameDir.Replace('/', Path.DirectorySeparatorChar).Replace('\\', Path.DirectorySeparatorChar);
+
         if (expected)
         {
-            Assert.StartsWith(path, resultPath);
-            Assert.DoesNotContain(gameDir, resultPath);
+            Assert.StartsWith(path.Replace('/', Path.DirectorySeparatorChar).Replace('\\', Path.DirectorySeparatorChar), resultPath);
+            Assert.DoesNotContain(expectedGameDir, resultPath);
         }
         else
         {
-            Assert.Contains(gameDir, resultPath);
+            Assert.Contains(expectedGameDir, resultPath);
         }
     }
 }

src/PetroglyphTools/PG.StarWarsGame.Engine.FileSystem.Test/IO/PetroglyphFileSystemTests.Names.cs

@@ -1,8 +1,9 @@
 using System;
-using System.Collections.Generic;
 using System.IO;
-using AnakinRaW.CommonUtilities.FileSystem;
 using Xunit;
+#if NETFRAMEWORK
+using AnakinRaW.CommonUtilities.FileSystem;
+#endif
 
 namespace PG.StarWarsGame.Engine.FileSystem.Test.IO;
 
@@ -34,34 +35,6 @@ public void GetFileName_Span(string path, string expected)
         Assert.Equal(expected, _pgFileSystem.GetFileName(path));
     }
 
-    public static IEnumerable<object[]> TestData_GetFileName_Volume()
-    {
-        yield return [":", ":"];
-        yield return [".:", ".:"];
-        yield return [".:.", ".:."];     // Not a valid drive letter
-        yield return ["file:", "file:"];
-        yield return [":file", ":file"];
-        yield return ["file:exe", "file:exe"];
-        yield return ["baz\\file:exe", "file:exe"];
-        yield return ["bar/baz/file:exe", "file:exe"];
-    }
-    
-    [Theory, MemberData(nameof(TestData_GetFileName_Volume))]
-    public void GetFileName_Volume(string path, string expected)
-    {
-        // We used to break on ':' on Windows. This is a valid file name character for alternate data streams.
-        // Additionally, the character can show up on unix volumes mounted to Windows.
-#if !NETFRAMEWORK
-        Assert.Equal(expected, Path.GetFileName(path));
-        Assert.Equal(expected, _pgFileSystem.GetFileName(path));
-#if Windows
-        Assert.Equal(_pgFileSystem.GetFileName(path), _fileSystem.Path.GetFileName(path.AsSpan()));
-#endif
-#endif
-
-        PathAssert.Equal(expected.AsSpan(), _pgFileSystem.GetFileName(path.AsSpan()));
-    }
-    
     public static TheoryData<string, string> TestData_GetFileNameWithoutExtension => new()
     {
         { "", "" },