basic support for VerificationTarget type

Author: AnakinRaW

modules/ModdingToolBase

@@ -39,7 +39,7 @@ internal class AutomaticModSelector(IServiceProvider serviceProvider) : ModSelec
         catch (GameNotFoundException)
         {
             Logger?.LogError(ModVerifyConstants.ConsoleEventId, "Unable to find games based of the given location '{SettingsGamePath}'. Consider specifying all paths manually.", settings.GamePath);
-            targetObject = null!;
+            targetObject = null;
             return null;
         }
 

src/ModVerify.CliApp/ModSelectors/AutomaticModSelector.cs

@@ -14,7 +14,9 @@ namespace AET.ModVerify.App.ModSelectors;
 
 internal class ConsoleModSelector(IServiceProvider serviceProvider) : ModSelectorBase(serviceProvider)
 {
-    public override GameLocations Select(GameInstallationsSettings settings, out IPhysicalPlayableObject targetObject,
+    public override GameLocations Select(
+        GameInstallationsSettings settings, 
+        out IPhysicalPlayableObject targetObject,
         out GameEngineType? actualEngineType)
     {
         var gameResult = GameFinderService.FindGames();

src/ModVerify.CliApp/ModSelectors/ConsoleModSelector.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Linq;
 using AET.ModVerify.App.Settings;
 using PG.StarWarsGame.Engine;
 using PG.StarWarsGame.Infrastructure;
@@ -22,8 +23,8 @@ public override GameLocations Select(
             throw new ArgumentException("Argument --game must be set.");
 
         return new GameLocations(
-            settings.ModPaths,
+            settings.ModPaths.ToList(),
             settings.GamePath!,
-            GetFallbackPaths(settings.FallbackGamePath, settings.AdditionalFallbackPaths));
+            GetFallbackPaths(settings.FallbackGamePath, settings.AdditionalFallbackPaths).ToList());
     }
 }

src/ModVerify.CliApp/ModSelectors/ManualModSelector.cs

@@ -34,7 +34,7 @@ protected GameLocations GetLocations(IPhysicalPlayableObject playableObject, Gam
     {
         var fallbacks = GetFallbackPaths(finderResult, playableObject, additionalFallbackPaths);
         var modPaths = GetModPaths(playableObject);
-        return new GameLocations(modPaths, playableObject.Game.Directory.FullName, fallbacks);
+        return new GameLocations(modPaths.ToList(), playableObject.Game.Directory.FullName, fallbacks.ToList());
     }
 
     private static IList<string> GetFallbackPaths(GameFinderResult finderResult, IPlayableObject gameOrMod, IList<string> additionalFallbackPaths)

src/ModVerify.CliApp/ModSelectors/ModSelectorBase.cs

@@ -25,16 +25,23 @@ public VerificationTarget CreateInstallationDataFromSettings(GameInstallationsSe
         {
             Engine = engineType.Value,
             Location = gameLocations,
-            Name = GetNameFromGameLocations(targetObject, gameLocations, engineType.Value)
+            Name = GetNameFromGameLocations(targetObject, gameLocations),
+            Version = GetTargetVersion(targetObject)
         };
     }
 
-    private static string GetNameFromGameLocations(IPlayableObject? targetObject, GameLocations gameLocations, GameEngineType engineType)
+    private static string GetNameFromGameLocations(IPlayableObject? targetObject, GameLocations gameLocations)
     {
         if (targetObject is not null)
             return targetObject.Name;
 
         var mod = gameLocations.ModPaths.FirstOrDefault();
         return mod ?? gameLocations.GamePath;
     }
+
+    private static string? GetTargetVersion(IPlayableObject? targetObject)
+    {
+        // TODO: Implement version retrieval from targetObject if possible
+        return null;
+    }
 }

src/ModVerify.CliApp/ModSelectors/SettingsBasedModSelector.cs

@@ -102,7 +102,7 @@ private async Task<int> RunVerify()
         if (!settings.CreateNewBaseline)
             return 0;
 
-        await WriteBaseline(reportSettings, allErrors, settings.NewBaselinePath).ConfigureAwait(false);
+        await WriteBaseline(verificationTarget, reportSettings, allErrors, settings.NewBaselinePath).ConfigureAwait(false);
         _logger?.LogInformation(ModVerifyConstants.ConsoleEventId, "Baseline successfully created.");
 
         return 0;
@@ -167,11 +167,12 @@ private async Task ReportErrors(IReadOnlyCollection<VerificationError> errors)
     }
 
     private async Task WriteBaseline(
+        VerificationTarget target,
         GlobalVerifyReportSettings reportSettings,
         IEnumerable<VerificationError> errors, 
         string baselineFile)
     {
-        var baseline = new VerificationBaseline(reportSettings.MinimumReportSeverity, errors);
+        var baseline = new VerificationBaseline(reportSettings.MinimumReportSeverity, errors, target);
 
         var fullPath = _fileSystem.Path.GetFullPath(baselineFile);
         _logger?.LogInformation(ModVerifyConstants.ConsoleEventId, "Writing Baseline to '{FullPath}'", fullPath);