Embed Steam Workshop fixtures for tests and replace skipped Steam live tests with local resources

Author: AnakinRaW

test/PG.StarWarsGame.Infrastructure.Test/ModServices/DirectoryModNameResolverTest.cs

@@ -3,7 +3,9 @@
 using AET.Modinfo.Model;
 using AET.Modinfo.Spec;
 using AET.Modinfo.Utilities;
+using Microsoft.Extensions.DependencyInjection;
 using PG.StarWarsGame.Infrastructure.Services.Name;
+using PG.StarWarsGame.Infrastructure.Services.Steam;
 using PG.StarWarsGame.Infrastructure.Testing.TestBases;
 using Xunit;
 
@@ -25,6 +27,12 @@ public void Ctor_NullArgs_Throws()
 
 public class OnlineModNameResolverTest : ModNameResolverTestBase
 {
+    protected override void SetupServices(IServiceCollection serviceCollection)
+    {
+        base.SetupServices(serviceCollection);
+        serviceCollection.AddSingleton<ISteamWorkshopWebpageDownloader>(new FakeSteamWorkshopWebpageDownloader());
+    }
+
     public override ModNameResolverBase CreateResolver()
     {
         return new OnlineModNameResolver(ServiceProvider);
@@ -36,10 +44,7 @@ public void Ctor_NullArgs_Throws()
         Assert.Throws<ArgumentNullException>(() => new OnlineModNameResolver(null!));
     }
 
-    [Theory(
-        Skip = TestEnvironment.SteamLiveTestsSkipReason,
-        SkipUnless = nameof(TestEnvironment.SteamLiveTestsEnabled),
-        SkipType = typeof(TestEnvironment))]
+    [Theory]
     [InlineData("path/1125718579", "z3r0x's mod version 3.5")]
     [InlineData("path/2978074984", "EAWFOC Mod Template")]
     public void ResolveName_Steam_WithoutModinfo_FindNameOnline(string path, string containsExpected)

test/PG.StarWarsGame.Infrastructure.Test/ModServices/FakeSteamWorkshopWebpageDownloader.cs

@@ -0,0 +1,24 @@
+using System;
+using System.Globalization;
+using System.Threading.Tasks;
+using HtmlAgilityPack;
+using PG.StarWarsGame.Infrastructure.Services.Steam;
+
+namespace PG.StarWarsGame.Infrastructure.Test.ModServices;
+
+internal sealed class FakeSteamWorkshopWebpageDownloader : ISteamWorkshopWebpageDownloader
+{
+    private const string FixtureNamespace = "PG.StarWarsGame.Infrastructure.Test.ModServices.Fixtures";
+
+    public Task<HtmlDocument> GetSteamWorkshopsPageHtmlAsync(ulong workshopId, CultureInfo? culture)
+    {
+        var doc = new HtmlDocument();
+        var resourceName = $"{FixtureNamespace}.workshop_{workshopId}.html";
+        var assembly = typeof(FakeSteamWorkshopWebpageDownloader).Assembly;
+        using var stream = assembly.GetManifestResourceStream(resourceName);
+        if (stream is null)
+            return Task.FromResult(doc);
+        doc.Load(stream);
+        return Task.FromResult(doc);
+    }
+}

test/PG.StarWarsGame.Infrastructure.Test/ModServices/Fixtures/workshop_1125718579.html

@@ -12,6 +12,12 @@ namespace PG.StarWarsGame.Infrastructure.Test.ModServices;
 
 public class OnlineModGameTypeResolverTest : ModGameTypeResolverTestBase
 {
+    protected override void SetupServices(IServiceCollection serviceCollection)
+    {
+        base.SetupServices(serviceCollection);
+        serviceCollection.AddSingleton<ISteamWorkshopWebpageDownloader>(new FakeSteamWorkshopWebpageDownloader());
+    }
+
     public override ModGameTypeResolver CreateResolver()
     {
         return new OnlineModGameTypeResolver(ServiceProvider);
@@ -20,13 +26,10 @@ public override ModGameTypeResolver CreateResolver()
     public static IEnumerable<object[]> GetOnlineModsData()
     {
         yield return ["1125718579", new[] {GameType.Foc}, GameType.Eaw]; //z3r0x's Mod (3.5)
-        yield return ["2508288191", new[] {GameType.Foc, GameType.Eaw}, null!]; //Mod Template
+        yield return ["2508288191", new[] {GameType.Foc, GameType.Eaw}, null!]; //Deep Core
     }
 
-    [Theory(
-        Skip = TestEnvironment.SteamLiveTestsSkipReason,
-        SkipUnless = nameof(TestEnvironment.SteamLiveTestsEnabled),
-        SkipType = typeof(TestEnvironment))]
+    [Theory]
     [MemberData(nameof(GetOnlineModsData))]
     public void Online_GetTagsFromSteamOnline(string knownId, ICollection<GameType> expectedTypes, GameType? incompatibleWith)
     {

test/PG.StarWarsGame.Infrastructure.Test/ModServices/Fixtures/workshop_2508288191.html

@@ -34,4 +34,8 @@
 	  <ProjectReference Include="..\..\src\PG.StarWarsGame.Infrastructure\PG.StarWarsGame.Infrastructure.csproj" />
 	  <ProjectReference Include="..\PG.StarWarsGame.Infrastructure.Testing\PG.StarWarsGame.Infrastructure.Testing.csproj" />
 	</ItemGroup>
+
+	<ItemGroup>
+	  <EmbeddedResource Include="ModServices\Fixtures\*.html" />
+	</ItemGroup>
 </Project>