Merge pull request #234 from AlamoEngine-Tools/develop

Public GameExeUtilities

Author: AnakinRaW

sampleApp/SampleApplication.csproj

@@ -7,7 +7,7 @@
 	</PropertyGroup>
 
 	<ItemGroup>
-	  <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.0" />
+	  <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.1" />
 	</ItemGroup>
 
 	<ItemGroup>

src/AET.SteamAbstraction/AET.SteamAbstraction.csproj

@@ -25,12 +25,12 @@
 		<PackageReference Include="Microsoft.Bcl.HashCode" Version="6.0.0" />
 		<PackageReference Include="AnakinRaW.CommonUtilities" Version="12.3.9" />
 		<PackageReference Include="AnakinRaW.CommonUtilities.FileSystem" Version="12.3.9" />
-		<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.0" />
-		<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.0" />
+		<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.1" />
+		<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.1" />
 		<PackageReference Include="Nullable" Version="1.3.1">
 		  <PrivateAssets>all</PrivateAssets>
 		  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>
-		<PackageReference Include="System.Text.Json" Version="10.0.0" />
+		<PackageReference Include="System.Text.Json" Version="10.0.1" />
 	</ItemGroup>
 </Project>

src/AET.SteamAbstraction/SteamAbstractionLayer.cs

@@ -19,7 +19,7 @@ public static void InitializeServices(IServiceCollection serviceCollection)
     {
         serviceCollection.AddSingleton<ISteamWrapperFactory>(sp => new SteamWrapperFactory(sp));
         serviceCollection.AddSingleton<ISteamRegistryFactory>(sp => new SteamRegistryFactory(sp));
-        serviceCollection.AddSingleton<IProcessHelper>(sp => new ProcessHelper());
+        serviceCollection.AddSingleton<IProcessHelper>(new ProcessHelper());
         serviceCollection.AddSingleton<ISteamLibraryFinder>(sp => new SteamLibraryFinder(sp));
     }
 }

src/AET.SteamAbstraction/SteamWrapper.cs

@@ -51,7 +51,7 @@ public bool? UserWantsOfflineMode
             try
             {
                 var config = SteamVdfReader.ReadLoginUsers(FileSystem.FileInfo.New(configFile));
-                return config.Users.Any(user => user.MostRecent && user.UserWantsOffline);
+                return config.Users.Any(user => user is { MostRecent: true, UserWantsOffline: true });
             }
             catch (SteamException)
             {

src/AET.SteamAbstraction/Vdf/Linq/VConditional.cs

@@ -8,7 +8,7 @@ namespace AET.SteamAbstraction.Vdf.Linq;
 
 internal class VConditional : VToken
 {
-    private readonly List<Token> _tokens = new();
+    private readonly List<Token> _tokens = [];
 
     public override VTokenType Type => VTokenType.Conditional;
 

src/AET.SteamAbstraction/Vdf/Linq/VObject.cs

@@ -75,7 +75,7 @@ public VToken? this[string key]
 
     public VObject()
     {
-        _children = new List<VToken>();
+        _children = [];
     }
 
     public VObject(VObject other)

src/PG.StarWarsGame.Infrastructure/Clients/Arguments/GameArgumentNames.cs

@@ -9,6 +9,7 @@ namespace PG.StarWarsGame.Infrastructure.Clients.Arguments;
 /// </summary>
 public static class GameArgumentNames
 {
+    // ReSharper disable InconsistentNaming
     internal const string ModListArg = "MODLIST";
     internal const string WindowedArg = "WINDOWED";
     internal const string MCEArg = "MCE";
@@ -68,6 +69,7 @@ public static class GameArgumentNames
     internal const string ConsoleCommandFileArg = "CONSOLECOMMANDFILE";
     internal const string ConnectPortArg = "CONNECTPORT";
     internal const string ConnectIPArg = "CONNECTIP";
+    // ReSharper enable InconsistentNaming
 
     internal static readonly IReadOnlyCollection<string> SupportedFlagArgumentNames =
         new ReadOnlyCollection<string>(

src/PG.StarWarsGame.Infrastructure/Clients/Arguments/GameArguments/AILogStyle.cs

@@ -2,6 +2,7 @@
 
 namespace PG.StarWarsGame.Infrastructure.Clients.Arguments.GameArguments;
 
+// ReSharper disable once InconsistentNaming
 /// <summary>
 /// Level of detail of LUA logging.
 /// </summary>

src/PG.StarWarsGame.Infrastructure/Clients/Arguments/GameArguments/GameArguments.cs

@@ -5,6 +5,8 @@
 
 namespace PG.StarWarsGame.Infrastructure.Clients.Arguments.GameArguments;
 
+// ReSharper disable InconsistentNaming
+
 #region Flags Normal
 
 /// <summary>
@@ -304,7 +306,7 @@ internal override string ValueToCommandLine()
 /// File location where LUA logging shall be stored to.
 /// </summary>
 /// <remarks>
-/// The directory of the file must already exists.
+/// The directory of the file must already exist.
 /// </remarks>
 public sealed class AILogFileArgument(IFileInfo value, IDirectoryInfo gameDir) : NamedArgument<IFileInfo>(GameArgumentNames.AILogFileArg, value, true)
 {

src/PG.StarWarsGame.Infrastructure/Clients/Utilities/GameExecutableFileUtilities.cs

@@ -6,32 +6,43 @@
 
 namespace PG.StarWarsGame.Infrastructure.Clients.Utilities;
 
-internal class GameExecutableFileUtilities
+/// <summary>
+/// Provides utility methods for locating game executable files for different game platforms and build types.
+/// </summary>
+public static class GameExecutableFileUtilities
 {
     private const string SteamFileNameBase = "StarWars";
     private const string SteamReleaseSuffix = "G";
     private const string SteamDebugSuffix = "I";
 
+    /// <summary>
+    /// Gets the executable file for the specified game and build type or <see langword="null"/> if not found.
+    /// </summary>
+    /// <param name="game">The game for which to locate the executable file.</param>
+    /// <param name="buildType">The build type of the game executable to locate.</param>
+    /// <returns>An <see cref="IFileInfo"/> representing the executable file if found; otherwise, <see langword="null"/>.</returns>
+    /// <exception cref="ArgumentNullException"><paramref name="game"/> is <see langword="null"/>.</exception>
     public static IFileInfo? GetExecutableForGame(IGame game, GameBuildType buildType)
     {
-        var exeFileName = GetExecutableFileName(game, buildType);
+        if (game == null) 
+            throw new ArgumentNullException(nameof(game));
 
-        if (string.IsNullOrEmpty(exeFileName))
+        // Only SteamGold supports debug builds
+        if (buildType == GameBuildType.Debug && game.Platform != GamePlatform.SteamGold)
             return null;
 
+        var exeFileName = GetExecutableFileName(game, buildType);
+
         return game.Directory
-            .EnumerateFiles(exeFileName!, SearchOption.TopDirectoryOnly)
+            .EnumerateFiles(exeFileName, SearchOption.TopDirectoryOnly)
             .FirstOrDefault();
     }
 
-    private static string? GetExecutableFileName(IGame game, GameBuildType buildType)
+    private static string GetExecutableFileName(IGame game, GameBuildType buildType)
     {
         if (game.Platform == GamePlatform.SteamGold)
             return GetSteamFileName(buildType);
 
-        if (buildType is GameBuildType.Debug)
-            return null;
-
         return game.Type switch
         {
             GameType.Eaw => PetroglyphStarWarsGameConstants.EmpireAtWarExeFileName,