Skip to content

fix: Convert Devise.sign_out_via to String#249

Merged
tvdeyen merged 1 commit into
mainfrom
fix-logout-method
Jan 29, 2026
Merged

fix: Convert Devise.sign_out_via to String#249
tvdeyen merged 1 commit into
mainfrom
fix-logout-method

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Jan 28, 2026

Since lastest Alchemy main (8.1.0.a) this needs
to be a String and cannot be a Symbol.

Since lastest Alchemy main (8.1.0.a) this needs
to be a String and cannot be a Symbol.
@tvdeyen tvdeyen added this to the 8.1 milestone Jan 28, 2026
tvdeyen added a commit to AlchemyCMS/alchemy-solidus that referenced this pull request Jan 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (fa27d9e) to head (566cd0f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          11       11           
  Lines         291      291           
=======================================
  Hits          287      287           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen merged commit 4d08640 into main Jan 29, 2026
41 checks passed
@tvdeyen tvdeyen deleted the fix-logout-method branch January 29, 2026 07:42
@alchemycms-bot alchemycms-bot Bot mentioned this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant