Don't render link when user login is nil#259
Merged
tvdeyen merged 1 commit intoAlchemyCMS:mainfrom Mar 25, 2026
Merged
Conversation
When user login is nil, Rails renders the URL as link text instead. To avoid this, the link is only rendered when user.login is present.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 11 11
Lines 291 291
=======================================
Hits 287 287
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
approved these changes
Mar 25, 2026
This was referenced Mar 25, 2026
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
added a commit
that referenced
this pull request
Mar 25, 2026
[8.0-stable] Merge pull request #259 from blish-guenzler/fix-login-link-to-dialog
tvdeyen
added a commit
that referenced
this pull request
Mar 25, 2026
[8.1-stable] Merge pull request #259 from blish-guenzler/fix-login-link-to-dialog
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When user login is nil, Rails renders the URL as link text instead. To avoid this, the link is only rendered when user.login is present.