Skip to content

Don't render link when user login is nil#259

Merged
tvdeyen merged 1 commit intoAlchemyCMS:mainfrom
blish-guenzler:fix-login-link-to-dialog
Mar 25, 2026
Merged

Don't render link when user login is nil#259
tvdeyen merged 1 commit intoAlchemyCMS:mainfrom
blish-guenzler:fix-login-link-to-dialog

Conversation

@blish-guenzler
Copy link
Copy Markdown
Contributor

When user login is nil, Rails renders the URL as link text instead. To avoid this, the link is only rendered when user.login is present.

When user login is nil, Rails renders the URL as link text instead.
To avoid this, the link is only rendered when user.login is present.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (4c5faf7) to head (4f6ecc0).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          11       11           
  Lines         291      291           
=======================================
  Hits          287      287           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen added backport-to-8.0-stable Needs a back port to 8.0-stable backport-to-8.1-stable Needs a back port to 8.1-stable labels Mar 25, 2026
@tvdeyen tvdeyen merged commit bfd994e into AlchemyCMS:main Mar 25, 2026
34 checks passed
@alchemycms-bot
Copy link
Copy Markdown

💚 All backports created successfully

Status Branch Result
8.0-stable
8.1-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

tvdeyen added a commit that referenced this pull request Mar 25, 2026
[8.0-stable] Merge pull request #259 from blish-guenzler/fix-login-link-to-dialog
tvdeyen added a commit that referenced this pull request Mar 25, 2026
[8.1-stable] Merge pull request #259 from blish-guenzler/fix-login-link-to-dialog
This was referenced Mar 25, 2026
@alchemycms-bot alchemycms-bot Bot mentioned this pull request Apr 13, 2026
@tvdeyen tvdeyen added the bug label Apr 13, 2026
@alchemycms-bot alchemycms-bot Bot mentioned this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-8.0-stable Needs a back port to 8.0-stable backport-to-8.1-stable Needs a back port to 8.1-stable bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants