Merge pull request #96 from AlchemyCMS/fix-ingredient-page-serializer

fix(ingredient/page_serializer): Wrap page in decorator

Author: tvdeyen

.github/workflows/lint.yml

@@ -10,7 +10,7 @@ jobs:
   Standard:
     runs-on: ubuntu-latest
     env:
-      ALCHEMY_BRANCH: 7.3-stable
+      ALCHEMY_BRANCH: 7.4-stable
     steps:
       - name: Checkout code
         uses: actions/checkout@v4

Gemfile

@@ -19,7 +19,7 @@ gem "sqlite3", "~> 2.2"
 
 alchemy_branch = ENV.fetch("ALCHEMY_BRANCH", "7.4-stable")
 gem "alchemy_cms", github: "AlchemyCMS/alchemy_cms", branch: alchemy_branch
-gem "alchemy-devise", github: "AlchemyCMS/alchemy-devise", branch: "main"
+gem "alchemy-devise", github: "AlchemyCMS/alchemy-devise", branch: "7.4-stable"
 
 gem "rubocop", require: false
 gem "standard", "~> 1.25", require: false

app/serializers/alchemy/json_api/ingredient_page_serializer.rb

@@ -19,7 +19,9 @@ class IngredientPageSerializer < BaseSerializer
         ingredient.page&.url_path
       end
 
-      has_one :page, record_type: :page, serializer: ::Alchemy::JsonApi::PageSerializer
+      has_one :page, record_type: :page, serializer: PageSerializer do |ingredient|
+        ingredient.page&.tap { Page.new(_1) }
+      end
     end
   end
 end

spec/serializers/alchemy/json_api/ingredient_page_serializer_spec.rb

@@ -3,8 +3,8 @@
 require "rails_helper"
 
 RSpec.describe Alchemy::JsonApi::IngredientPageSerializer do
-  let(:ingredient) { FactoryBot.build_stubbed(:alchemy_ingredient_page, page: page) }
-  let(:page) { FactoryBot.build_stubbed(:alchemy_page) }
+  let(:ingredient) { FactoryBot.create(:alchemy_ingredient_page, page: page) }
+  let(:page) { FactoryBot.create(:alchemy_page) }
 
   let(:serializer) { described_class.new(ingredient) }
 
@@ -38,7 +38,7 @@
     let(:page) { nil }
 
     describe "attributes" do
-      it "has no ingredient" do
+      it "has no value" do
         expect(subject[:value]).to be_nil
       end