Skip to content

Commit aa5c6c0

Browse files
authored
Merge pull request #116 from AlchemyCMS/bump-alchemy-requirement
Bump minimum Alchemy version to 7.2.0
2 parents 3070470 + 184c9b4 commit aa5c6c0

5 files changed

Lines changed: 4 additions & 23 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,14 @@ jobs:
1313
fail-fast: false
1414
matrix:
1515
alchemy_branch:
16-
- 7.0-stable
17-
- 7.1-stable
1816
- 7.2-stable
1917
- 7.3-stable
2018
- 7.4-stable
2119
ruby:
22-
- "3.1"
2320
- "3.2"
2421
- "3.3"
2522
- "3.4"
2623
exclude:
27-
- alchemy_branch: 7.0-stable
28-
ruby: "3.4"
29-
- alchemy_branch: 7.1-stable
30-
ruby: "3.4"
3124
- alchemy_branch: 7.2-stable
3225
ruby: "3.4"
3326
- alchemy_branch: 7.3-stable

alchemy-json_api.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
1818

1919
spec.files = Dir["{app,config,db,lib}/**/*", "LICENSE", "Rakefile", "README.md"]
2020

21-
spec.add_dependency "alchemy_cms", [">= 7.0.0.a", "< 8"]
21+
spec.add_dependency "alchemy_cms", [">= 7.2.0", "< 8"]
2222
spec.add_dependency "jsonapi.rb", [">= 1.6.0", "< 2.2"]
2323

2424
spec.add_development_dependency "factory_bot"

app/controllers/alchemy/json_api/admin/pages_controller.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,7 @@ def caching_options
1818
end
1919

2020
def set_current_preview
21-
if Alchemy.const_defined?(:Current)
22-
Alchemy::Current.preview_page = @page
23-
else
24-
Alchemy::Page.current_preview = @page
25-
end
21+
Alchemy::Current.preview_page = @page
2622
end
2723

2824
def page_cache_key(page)

app/controllers/alchemy/json_api/pages_controller.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,7 @@ def base_page_scope
138138
end
139139

140140
def current_language
141-
if Alchemy.const_defined?(:Current)
142-
Alchemy::Current.language
143-
else
144-
Alchemy::Language.current
145-
end
141+
Alchemy::Current.language
146142
end
147143

148144
def jsonapi_serializer_class(_resource, _is_collection)

spec/controllers/alchemy/json_api/admin/pages_controller_spec.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,7 @@
1717

1818
it "stores page as preview" do
1919
get :show, params: {path: page.urlname}
20-
if Alchemy.const_defined?(:Current)
21-
expect(Alchemy::Current.preview_page).to eq(page)
22-
else
23-
expect(Alchemy::Page.current_preview).to eq(page.id)
24-
end
20+
expect(Alchemy::Current.preview_page).to eq(page)
2521
end
2622
end
2723
end

0 commit comments

Comments
 (0)