Commit 0a63be1
committed
refactor(Tinymce): Extend HTMLElement directly
Dropping the AlchemyHTMLElement base class avoids reading innerHTML at
construction time and rewriting it during render, which violated the
Web Components spec and contributed to the SortableJS drag-clone crash.
The spinner is now appended via insertAdjacentHTML with an idempotent
guard, so re-inserting the element does not stack multiple spinners.
All setup (classname, min-height, editor hiding, observer, theme
listener) is performed in connectedCallback.1 parent efbc812 commit 0a63be1
3 files changed
Lines changed: 18 additions & 24 deletions
File tree
- app
- assets/builds/alchemy
- javascript/alchemy_admin/components
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
8 | | - | |
| 7 | + | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
14 | | - | |
| 13 | + | |
15 | 14 | | |
16 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
17 | 28 | | |
18 | 29 | | |
19 | 30 | | |
| |||
43 | 54 | | |
44 | 55 | | |
45 | 56 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
| 57 | + | |
| 58 | + | |
50 | 59 | | |
51 | 60 | | |
52 | 61 | | |
53 | 62 | | |
54 | 63 | | |
55 | 64 | | |
56 | 65 | | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | 66 | | |
73 | 67 | | |
74 | 68 | | |
| |||
0 commit comments