Commit 2f42736
committed
fix(PictureThumbnail): Remove ineffective lazy loading
Setting image.loading = "lazy" after image.src starts the fetch was a
no-op. The loading attribute is consulted before fetch begins, and for
detached Image instances the fetch starts immediately when src is set.
The attribute never actually deferred anything here. Removing it makes
the code honest about what happens and prevents accidental activation
if the order is ever reversed in a context where lazy would be harmful,
such as the crop dialog.1 parent 93a8023 commit 2f42736
4 files changed
Lines changed: 2 additions & 13 deletions
File tree
- app
- assets/builds/alchemy
- javascript/alchemy_admin/components
- spec/javascript/alchemy_admin/components
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | 46 | | |
48 | 47 | | |
49 | 48 | | |
| |||
Lines changed: 0 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | 155 | | |
166 | 156 | | |
167 | 157 | | |
| |||
0 commit comments