Extend url path class to handle wildcard params

Allow the setting of wildcard parameter in url_path class. It is introducing a new wildcard_params hash to not mix that set of params with the default optional_params hash.

Author: kulturbande

app/models/alchemy/page.rb

@@ -305,8 +305,8 @@ def find_elements(options = {})
     # = The url_path for this page
     #
     # @see Alchemy::Page::UrlPath#call
-    def url_path(optional_params = {})
-      self.class.url_path_class.new(self, optional_params).call
+    def url_path(optional_params = {}, wildcard_params: {})
+      self.class.url_path_class.new(self, optional_params, wildcard_params: wildcard_params).call
     end
 
     # The page's view partial is dependent from its page layout

app/models/alchemy/page/url_path.rb

@@ -20,11 +20,12 @@ class Page
     #     link_to page.url
     #
     class UrlPath
-      def initialize(page, optional_params = {})
+      def initialize(page, optional_params = {}, wildcard_params: {})
         @page = page
         @language = @page.language
         @site = @language.site
         @optional_params = optional_params
+        @wildcard_params = wildcard_params
       end
 
       def call
@@ -64,7 +65,11 @@ def language_path
       end
 
       def page_path
-        "#{root_path}#{@page.urlname}"
+        urlname = @page.urlname
+        @wildcard_params.each do |key, val|
+          urlname = urlname.gsub(":#{key}", val.to_s)
+        end
+        "#{root_path}#{urlname}"
       end
 
       def root_path

spec/models/alchemy/page/url_path_spec.rb

@@ -76,6 +76,39 @@
     end
   end
 
+  context "with wildcard params" do
+    let(:parent) { create(:alchemy_page, name: "Products") }
+    let(:page) { create(:alchemy_page, parent: parent, name: "Product Detail", page_layout: "page_with_wildcard_url") }
+
+    subject(:url) { described_class.new(page, wildcard_params: {slug: 42}).call }
+
+    it "substitutes wildcards in the urlname" do
+      is_expected.to eq("/products/42")
+    end
+  end
+
+  context "with wildcard params as ActionController::Parameters" do
+    let(:parent) { create(:alchemy_page, name: "Products") }
+    let(:page) { create(:alchemy_page, parent: parent, name: "Product Detail", page_layout: "page_with_wildcard_url") }
+
+    subject(:url) { described_class.new(page, wildcard_params: ActionController::Parameters.new({slug: 42})).call }
+
+    it "substitutes wildcards in the urlname" do
+      is_expected.to eq("/products/42")
+    end
+  end
+
+  context "with wildcard and query params mixed" do
+    let(:parent) { create(:alchemy_page, name: "Products") }
+    let(:page) { create(:alchemy_page, parent: parent, name: "Product Detail", page_layout: "page_with_wildcard_url") }
+
+    subject(:url) { described_class.new(page, {page: 2}, wildcard_params: {slug: 42}).call }
+
+    it "substitutes wildcards and appends remaining params as query string" do
+      is_expected.to eq("/products/42?page=2")
+    end
+  end
+
   context "mounted on a non-root path" do
     let(:page) do
       create(:alchemy_page)

spec/models/alchemy/page_spec.rb

@@ -344,7 +344,7 @@ module Alchemy
       end
 
       context "with a custom url_path_class" do
-        let(:url_path_class) { Struct.new(:page, :params) { def call = "/bar" } }
+        let(:url_path_class) { Struct.new(:page, :params, :wildcard_params) { def call = "/bar" } }
 
         before do
           described_class.url_path_class = url_path_class
@@ -356,6 +356,14 @@ module Alchemy
 
         it { is_expected.to eq("/bar") }
       end
+
+      context "with wildcard params" do
+        let(:page) { create(:alchemy_page, page_layout: "page_with_wildcard_url") }
+
+        subject { page.url_path(wildcard_params: {slug: 42}) }
+
+        it { is_expected.to eq("/42") }
+      end
     end
 
     describe ".all_from_clipboard_for_select" do