Skip to content

[8.1-stable] Remove lazy loading from thumbnail #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdeyen merged 2 commits into from
Apr 22, 2026
Merged

[8.1-stable] Remove lazy loading from thumbnail #3848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc83e08
fix(PictureThumbnail): Scope image CSS to direct children
tvdeyen Apr 22, 2026
b850676
fix(PictureThumbnail): Remove ineffective lazy loading
tvdeyen Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/builds/alchemy/admin.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions app/assets/builds/alchemy/alchemy_admin.min.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions app/assets/builds/alchemy/alchemy_admin.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion app/javascript/alchemy_admin/components/picture_thumbnail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ export default class PictureThumbnail extends HTMLElement {
if (alt) {
this.image.alt = alt
}
this.image.loading = "lazy"
}

start(src) {
Expand Down
4 changes: 2 additions & 2 deletions app/stylesheets/alchemy/admin/images.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
alchemy-picture-thumbnail {
&[loading] {
img {
> img {
opacity: 0;
}
}

img {
> img {
opacity: 1;
transition: opacity var(--transition-duration);
}
Expand Down
10 changes: 0 additions & 10 deletions spec/javascript/alchemy_admin/components/picture_thumbnail.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,16 +152,6 @@ describe("alchemy-picture-thumbnail", () => {
expect(element.image.alt).not.toBe("Test image")
})

it("sets loading to lazy", () => {
const element = renderComponent(
"alchemy-picture-thumbnail",
"<alchemy-picture-thumbnail></alchemy-picture-thumbnail>"
)
element.createImage("https://example.com/test.jpg")

expect(element.image.loading).toBe("lazy")
})

it("uses default src from attribute", () => {
const element = renderComponent(
"alchemy-picture-thumbnail",
Expand Down
Loading