Skip to content

chore(PageVersion): Use instance methods of Publishable #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdeyen merged 1 commit into from
Apr 27, 2026
+0 −26
Merged

chore(PageVersion): Use instance methods of Publishable #3853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions app/models/alchemy/page_version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,32 +29,6 @@ class << self

before_destroy :delete_elements

# Determines if this version is public
#
# Takes the two timestamps +public_on+ and +public_until+
# and returns true if the time given (+Time.current+ per default)
# is in this timespan.
#
# @param time [DateTime] (Time.current)
# @returns Boolean
def public?(time = Current.preview_time)
already_public_for?(time) && still_public_for?(time)
end

# Determines if this version is already public for given time
# @param time [DateTime] (Current.preview_time)
# @returns Boolean
def already_public_for?(time = Current.preview_time)
!public_on.nil? && public_on <= time
end

# Determines if this version is still public for given time
# @param time [DateTime] (Current.preview_time)
# @returns Boolean
def still_public_for?(time = Current.preview_time)
public_until.nil? || public_until >= time
end

def element_repository
ElementsRepository.new(elements)
end
Expand Down
Loading