Skip to content

feat: Split publication schedule forms#3865

Open
tvdeyen wants to merge 3 commits intomainfrom
split-element-schedule-form
Open

feat: Split publication schedule forms#3865
tvdeyen wants to merge 3 commits intomainfrom
split-element-schedule-form

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Apr 29, 2026

What is this pull request for?

When extensions or apps want to add more fields to the page or element publication
schedule forms, they can do so now by overriding the partial and drop or re-use the
existing fields.

Checklist

@tvdeyen tvdeyen added this to the 8.3 milestone Apr 29, 2026
@tvdeyen tvdeyen requested a review from a team as a code owner April 29, 2026 17:27
@tvdeyen tvdeyen added the enhancement New feature or enhancement label Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.08%. Comparing base (7903e24) to head (d8211c8).

Files with missing lines Patch % Lines
...nents/alchemy/admin/element_schedule_timestamps.rb 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3865      +/-   ##
==========================================
- Coverage   98.09%   98.08%   -0.01%     
==========================================
  Files         325      327       +2     
  Lines        8650     8669      +19     
==========================================
+ Hits         8485     8503      +18     
- Misses        165      166       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen force-pushed the split-element-schedule-form branch from e06f06d to 13951f2 Compare May 4, 2026 09:28
@tvdeyen
Copy link
Copy Markdown
Member Author

tvdeyen commented May 4, 2026

Let's look into a way to use a component registry with configurable fields instead.

@tvdeyen tvdeyen marked this pull request as draft May 4, 2026 09:41
Comment thread app/views/alchemy/admin/elements/_schedule_timestamps.html.erb Outdated
Comment thread app/views/alchemy/admin/pages/_schedule_fields.html.erb Outdated
@tvdeyen tvdeyen force-pushed the split-element-schedule-form branch from 13951f2 to ba126c0 Compare May 5, 2026 14:06
tvdeyen added 3 commits May 5, 2026 16:06
If an extension or app wants to add more
fields to the element publication schedule
form they can override the schedule_fields
partial and even re-use or drop the timestamps.
Easier to overwrite if necessary
@tvdeyen tvdeyen force-pushed the split-element-schedule-form branch from ba126c0 to d8211c8 Compare May 5, 2026 14:07
@tvdeyen tvdeyen marked this pull request as ready for review May 5, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant