Skip to content

Commit 61ccaf9

Browse files
RyeMuttclaude
andcommitted
Invalidate cached suffix geometry in LLFolderViewItem::refreshSuffix
LLFontVertexBuffer::render does not compare the rendered string, so any path that changes mLabelSuffix must reset the cached geometry or draw() replays the old text. refresh() already does this; mirror it in refreshSuffix(), which is reached via arrange() for items deferred from postBuild(). Currently the buffer is always null on that path (items arrange before first draw), so this is hardening against reordering or future callers rather than a user-visible defect. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent de88742 commit 61ccaf9

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

indra/llui/llfolderviewitem.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -447,6 +447,13 @@ void LLFolderViewItem::refreshSuffix()
447447
mLabelStyle = vmi->getLabelStyle();
448448
pLabelFont = nullptr;
449449
mLabelSuffix = utf8str_to_wstring(vmi->getLabelSuffix());
450+
// LLFontVertexBuffer::render doesn't compare the string, so cached
451+
// geometry must be invalidated here or it would replay the old suffix.
452+
// (A style change is covered by render's font-pointer compare.)
453+
if (mSuffixFontBuffer)
454+
{
455+
mSuffixFontBuffer->reset();
456+
}
450457
}
451458

452459
mLabelWidthDirty = true;

0 commit comments

Comments
 (0)