Skip to content

Commit 90cdc3e

Browse files
Apply suggestions from code review
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
1 parent 539dec8 commit 90cdc3e

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

.github/workflows/build.yaml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -477,6 +477,7 @@ jobs:
477477
- name: Checkout code
478478
uses: actions/checkout@v7
479479
with:
480+
persist-credentials: false
480481
submodules: recursive
481482
ref: ${{ github.event.pull_request.head.sha || github.sha }}
482483

@@ -564,22 +565,29 @@ jobs:
564565
fi
565566
566567
- name: Find Velopack installer
568+
id: find-installer
567569
shell: bash
568570
run: |
569-
installer="$(ls -t .app/*_Setup.exe | head -n 1)"
570-
echo "installer=$installer" >> "$GITHUB_ENV"
571+
installer="$(ls -t .app/*_Setup.exe 2>/dev/null | head -n 1 || true)"
572+
if [[ -z "$installer" ]]; then
573+
echo "::error::No Velopack installer found under .app"
574+
exit 1
575+
fi
576+
echo "installer=$installer" >> "$GITHUB_OUTPUT"
571577
572578
- name: Post the installer
573579
uses: actions/upload-artifact@v7
574580
with:
575581
name: "Windows-installer"
576-
path: ${{ env.installer }}
582+
path: ${{ steps.find-installer.outputs.installer }}
583+
if-no-files-found: error
577584

578585
- name: Upload Velopack releases
579586
uses: actions/upload-artifact@v7
580587
with:
581588
name: "Windows-releases"
582589
path: Releases/
590+
if-no-files-found: error
583591

584592
# sign-and-package-mac:
585593
# env:

0 commit comments

Comments
 (0)