Address review feedback for PR #330

Author: RyeMutt

indra/llui/llspellcheck.cpp

@@ -297,11 +297,15 @@ void LLSpellChecker::refreshDictionaryMap()
 
 void LLSpellChecker::addToCustomDictionary(const std::string& word)
 {
-    addToDictFile(getDictionaryUserPath() + DICT_FILE_CUSTOM, word);
     std::string word_lower(word);
     LLStringUtil::toLower(word_lower);
-    mAcceptedWords.insert(word_lower);
-    sSettingsChangeSignal();
+    if (!mAcceptedWords.contains(word_lower))
+    {
+        addToDictFile(getDictionaryUserPath() + DICT_FILE_CUSTOM, word);
+
+        mAcceptedWords.insert(word_lower);
+        sSettingsChangeSignal();
+    }
 }
 
 void LLSpellChecker::addToIgnoreList(const std::string& word)

indra/llui/llspellcheckengine_hunspell.cpp

@@ -97,7 +97,7 @@ namespace
         const std::string user_path = LLSpellChecker::getDictionaryUserPath();
         for (const std::string& name : candidate_names)
         {
-            if ( (gDirUtilp->fileExists(user_path + name + ".dic")) || (gDirUtilp->fileExists(app_path + name + ".dic")) )
+            if ( (gDirUtilp->fileExists(user_path + name + ".dic") && gDirUtilp->fileExists(user_path + name + ".aff")) || (gDirUtilp->fileExists(app_path + name + ".dic") && gDirUtilp->fileExists(app_path + name + ".aff")) )
             {
                 installed.insert(name);
             }

indra/llui/llspellcheckengine_win32.cpp

@@ -72,6 +72,8 @@ namespace
 
     LLWinSpellEngine::LLWinSpellEngine()
     {
+        llassert(on_main_thread());
+
         // The Windows Spell Checking API is COM-based and the viewer keeps no standing COM apartment
         // on the main thread, so own one for this engine's lifetime. Apartment-threaded (STA) matches
         // every existing scoped COM site and is reference-counted, so it nests safely.
@@ -87,6 +89,8 @@ namespace
 
     LLWinSpellEngine::~LLWinSpellEngine()
     {
+        llassert(on_main_thread());
+
         // Release COM interfaces before tearing down the apartment.
         if (mChecker)
         {