fix(tests): resolve install.test.ts failures

- Add git init in beforeEach for install tests (required by CLI)
- Create separate test directory for --llm option tests
- Fix nested describe block isolation issues
- Update test-summary.md with current coverage

All 138 unit tests now passing ✅

Author: Alenryuichi

_bmad-output/implementation-artifacts/tests/test-summary.md

@@ -1,99 +1,98 @@
 # Test Automation Summary
 
-**Generated**: 2026-02-03
-**Framework**: Vitest v4.0.18
-**Project**: openmemory-plus CLI
+**Project**: OpenMemory Plus  
+**Date**: 2026-02-03  
+**Framework**: Vitest + Bash E2E  
 
 ## Generated Tests
 
-### Unit Tests
-
-| File | Tests Added | Description |
-|------|-------------|-------------|
-| `tests/mcp-config.test.ts` | +9 | MCP configuration edge cases, multi-IDE support, path validation |
-| `tests/detector.test.ts` | +1 | checkAllDependencies integration test |
-
-### Test Details
-
-#### mcp-config.test.ts (New Tests)
-- [x] `checkMcpConfigured` - should return false for unknown IDE
-- [x] `configureMcpForIdes` - should configure multiple IDEs
-- [x] `configureMcpForIdes` - should handle mixed valid and invalid IDEs
-- [x] `IDE config paths` - should return correct path for cursor
-- [x] `IDE config paths` - should return correct path for claude (CLI)
-- [x] `IDE config paths` - should return correct path for claude-desktop on darwin
-- [x] `IDE config paths` - should return correct path for gemini on darwin
-- [x] `configureMcpForIde edge cases` - should handle invalid JSON in existing config
-- [x] `configureMcpForIde edge cases` - should create cursor config in correct location
-
-#### detector.test.ts (New Tests)
-- [x] `checkAllDependencies` - should return status for all dependencies
+### Unit Tests (Vitest)
+
+| Test File | Tests | Status |
+|-----------|-------|--------|
+| `cli.test.ts` | 7 | ✅ |
+| `status.test.ts` | 9 | ✅ |
+| `doctor.test.ts` | 6 | ✅ |
+| `install.test.ts` | 13 | ✅ |
+| `deps.test.ts` | 11 | ✅ |
+| `detector.test.ts` | 7 | ✅ |
+| `platform.test.ts` | 18 | ✅ |
+| `mcp-config.test.ts` | 18 | ✅ |
+| `providers.test.ts` | 22 | ✅ |
+| `graph.test.ts` | 12 | ✅ |
+| `decay.test.ts` | 15 | ✅ |
+| **Total** | **138** | ✅ |
+
+### E2E Tests (Bash)
+
+| Test Suite | Tests | Status |
+|------------|-------|--------|
+| `run-sandbox.sh` (DinD) | 6 | ✅ |
+| `run-e2e-full.sh` (Full) | 15 | ✅ |
+| **Total** | **21** | ✅ |
 
 ## Coverage
 
-### Before
-| Module | Statements | Branches | Functions | Lines |
-|--------|------------|----------|-----------|-------|
-| All files | 23.12% | 22.74% | 36.00% | 22.99% |
-| detector.ts | 3.27% | 13.33% | 10.00% | 3.33% |
-| mcp-config.ts | 24.34% | 21.50% | 25.00% | 24.66% |
-
-### After
-| Module | Statements | Branches | Functions | Lines |
-|--------|------------|----------|-----------|-------|
-| All files | **27.67%** | **25.49%** | **45.33%** | **27.65%** |
-| detector.ts | **68.85%** | **44.44%** | **100%** | **70.00%** |
-| mcp-config.ts | **33.55%** | **25.80%** | **42.85%** | **34.00%** |
+### Source Files
+
+| Module | File | Test Coverage |
+|--------|------|---------------|
+| Commands | `install.ts` | ✅ Covered |
+| Commands | `status.ts` | ✅ Covered |
+| Commands | `doctor.ts` | ✅ Covered |
+| Commands | `deps.ts` | ✅ Covered |
+| Lib | `detector.ts` | ✅ Covered |
+| Lib | `platform.ts` | ✅ Covered |
+| Lib | `mcp-config.ts` | ✅ Covered |
+| Lib | `providers.ts` | ✅ Covered |
+| Memory | `graph.ts` | ✅ Covered |
+| Memory | `decay.ts` | ✅ Covered |
+
+### E2E Coverage
+
+| Feature | Covered |
+|---------|---------|
+| CLI Version/Help | ✅ |
+| Status Command | ✅ |
+| Doctor Command | ✅ |
+| Install Command | ✅ |
+| Multi-IDE Support | ✅ |
+| LLM Provider Config | ✅ |
+| Qdrant Connection | ✅ |
+| Ollama Connection | ✅ |
+| BGE-M3 Embedding | ✅ |
+| Memory Vector Generation | ✅ |
+| Memory Collection | ✅ |
+| Memory Search API | ✅ |
+
+## Test Commands
+
+```bash
+# Unit tests
+npm test                    # Run all unit tests
+npm run test:watch          # Watch mode
+npm run test:coverage       # Coverage report
+
+# E2E tests
+npm run test:e2e            # Lightweight DinD sandbox
+npm run test:e2e:full       # Full E2E with memory validation
+```
 
-### Improvement Summary
-- **Total coverage**: +4.55% (23.12% → 27.67%)
-- **detector.ts**: +65.58% (3.27% → 68.85%)
-- **mcp-config.ts**: +9.21% (24.34% → 33.55%)
-- **src/lib overall**: +16.21% (41.44% → 57.65%)
+## Recent Fixes
 
-## Test Results
+### 2026-02-03
 
-```
-✓ tests/status.test.ts (9 tests)
-✓ tests/doctor.test.ts (6 tests)
-✓ tests/providers.test.ts (22 tests)
-✓ tests/graph.test.ts (12 tests)
-✓ tests/decay.test.ts (15 tests)
-✓ tests/mcp-config.test.ts (18 tests) ← +9 new
-✓ tests/deps.test.ts (11 tests)
-✓ tests/detector.test.ts (7 tests) ← +1 new
-✓ tests/platform.test.ts (18 tests)
-✓ tests/cli.test.ts (7 tests)
-✓ tests/install.test.ts (13 tests)
-
-Test Files: 11 passed
-Tests: 138 passed (was 128)
-Duration: ~114s
-```
+- Fixed `install.test.ts` - Added git init in beforeEach
+- Fixed nested describe blocks - Separate test directories for `--llm` tests
+- All 138 unit tests passing
+- All 15 E2E tests passing
 
 ## Next Steps
 
-1. ✅ Run tests in CI (already configured in `prepublishOnly`)
-2. Consider adding more edge case tests for:
-   - `src/commands/install.ts` (0% coverage)
-   - `src/commands/status.ts` (0% coverage)
-   - `src/commands/doctor.ts` (0% coverage)
-3. Add E2E tests for full CLI workflow
-
-## Validation Checklist
-
-- [x] Tests use standard test framework APIs (Vitest)
-- [x] Tests cover happy path
-- [x] Tests cover error cases (invalid IDE, invalid JSON)
-- [x] All generated tests run successfully
-- [x] Tests use proper assertions
-- [x] Tests have clear descriptions
-- [x] No hardcoded waits or sleeps
-- [x] Tests are independent (no order dependency)
-- [x] Test summary created
-- [x] Tests saved to appropriate directories
-- [x] Summary includes coverage metrics
+- [ ] Add CI/CD pipeline with E2E tests
+- [ ] Increase coverage for edge cases
+- [ ] Add performance benchmarks
 
 ---
 
-**Done!** Tests generated and verified. ✅
+*Generated by Quinn QA - Automate Workflow*

cli/tests/install.test.ts

@@ -13,6 +13,11 @@ describe('install command', () => {
       rmSync(TEST_DIR, { recursive: true, force: true });
     }
     mkdirSync(TEST_DIR, { recursive: true });
+    // Initialize git repo (required for install command)
+    execSync('git init -q && git config user.email "test@test.com" && git config user.name "Test"', {
+      cwd: TEST_DIR,
+      stdio: 'pipe',
+    });
   });
 
   afterEach(() => {
@@ -141,26 +146,45 @@ describe('install command', () => {
 
   // H2 Fix: Add tests for --llm option
   describe('--llm option', () => {
+    const LLM_TEST_DIR = '/tmp/omp-test-llm';
+
+    beforeEach(() => {
+      if (existsSync(LLM_TEST_DIR)) {
+        rmSync(LLM_TEST_DIR, { recursive: true, force: true });
+      }
+      mkdirSync(LLM_TEST_DIR, { recursive: true });
+      execSync('git init -q && git config user.email "test@test.com" && git config user.name "Test"', {
+        cwd: LLM_TEST_DIR,
+        stdio: 'pipe',
+      });
+    });
+
+    afterEach(() => {
+      if (existsSync(LLM_TEST_DIR)) {
+        rmSync(LLM_TEST_DIR, { recursive: true, force: true });
+      }
+    });
+
     it('should accept valid provider via --llm option', () => {
       const output = execSync(`node ${CLI_PATH} install -i augment -y --skip-deps --llm deepseek`, {
-        cwd: TEST_DIR,
+        cwd: LLM_TEST_DIR,
         encoding: 'utf-8',
       });
 
       expect(output).toContain('DeepSeek');
-      expect(existsSync(join(TEST_DIR, '_omp', 'commands', 'memory.md'))).toBe(true);
+      expect(existsSync(join(LLM_TEST_DIR, '_omp', 'commands', 'memory.md'))).toBe(true);
     });
 
     it('should warn about invalid provider in non-interactive mode', () => {
       const output = execSync(`node ${CLI_PATH} install -i augment -y --skip-deps --llm invalid_provider`, {
-        cwd: TEST_DIR,
+        cwd: LLM_TEST_DIR,
         encoding: 'utf-8',
       });
 
       expect(output).toContain('未知的 Provider');
       expect(output).toContain('invalid_provider');
       // Should still complete installation
-      expect(existsSync(join(TEST_DIR, '_omp', 'commands', 'memory.md'))).toBe(true);
+      expect(existsSync(join(LLM_TEST_DIR, '_omp', 'commands', 'memory.md'))).toBe(true);
     });
 
     it('should show --llm option in help', () => {
@@ -174,11 +198,11 @@ describe('install command', () => {
 
     it('should copy patches directory for LLM provider support', () => {
       execSync(`node ${CLI_PATH} install -i augment -y --skip-deps --llm ollama`, {
-        cwd: TEST_DIR,
+        cwd: LLM_TEST_DIR,
         stdio: 'pipe',
       });
 
-      expect(existsSync(join(TEST_DIR, '_omp', 'patches', 'categorization.py'))).toBe(true);
+      expect(existsSync(join(LLM_TEST_DIR, '_omp', 'patches', 'categorization.py'))).toBe(true);
     });
   });