Skip to content

Fix export order inconsistency#486

Open
gustavo-shigueo wants to merge 3 commits into
mainfrom
export_order
Open

Fix export order inconsistency#486
gustavo-shigueo wants to merge 3 commits into
mainfrom
export_order

Conversation

@gustavo-shigueo

Copy link
Copy Markdown
Collaborator

Goal

Fix inconsistent export order
Closes #479

Changes

Change merge code to no longer depend on the export type prefix

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@gustavo-shigueo
gustavo-shigueo marked this pull request as ready for review March 7, 2026 21:27
@B-2U

B-2U commented Mar 8, 2026

Copy link
Copy Markdown

It looks good to me! Though, in my humble opinion, the .nth(2) deserves a comment.

@gustavo-shigueo
gustavo-shigueo requested a review from NyxCode March 8, 2026 13:04
@kasbah kasbah mentioned this pull request Mar 17, 2026
3 tasks
@B-2U

B-2U commented Apr 15, 2026

Copy link
Copy Markdown

It seems that Nyx has been inactive for months :(

@gustavo-shigueo

Copy link
Copy Markdown
Collaborator Author

He has mentioned before that he's quite busy at work, I'm sure when he has some time he'll take a look at the PRs but it's not easy making time for open source when your boss is constantly breathing down your neck lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Race condition when generate multiple type into same file

2 participants