Skip to content

ci: Update to check-spelling@v0.0.21#3172

Merged
AlexRogalskiy merged 14 commits intoAlexRogalskiy:masterfrom
jsoref:spell-check
Apr 27, 2026
Merged

ci: Update to check-spelling@v0.0.21#3172
AlexRogalskiy merged 14 commits intoAlexRogalskiy:masterfrom
jsoref:spell-check

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Aug 22, 2022

Description

Updates to check-spelling@v0.0.21
https://github.com/check-spelling/spell-check-this/blob/7f19ef86816022985ad456efa7881918d4a9d6a4/.github/workflows/spelling.yml

Also refreshes .github/actions/spelling

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

I tried using a fork to test the PR flow and lots of things broke. I'm happy to adjust the commit messages/style bits.

@changelogg
Copy link
Copy Markdown

changelogg Bot commented Aug 22, 2022

Hey! Changelogs info seems to be missing or might be in incorrect format.
Please use the below template in PR description to ensure Changelogg can detect your changes:
- (tag) changelog_text
or
- tag: changelog_text
OR
You can add tag in PR header or while doing a commit too
(tag) PR header
or
tag: PR header
Valid tags: added / feat, changed, deprecated, fixed / fix, removed, security, build, ci, chore, docs, perf, refactor, revert, style, test
Thanks!
For more info, check out changelogg docs

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Aug 22, 2022

Thank you for opening your first PR! 🎉 We are very happy and would like to thank you very much for your contribution. If everything checks out, we'll make sure to review the PR as soon as possible and give feedback. In the meantime, to make the reviewing process as fast as possible, you can help us by checking the following things:

  • Did you follow the JSStandard coding style? - Did you comment everywhere where the necessity of a piece of code or the
    way it was implemented is not immediately obvious?
  • Did you attempt to stick as much to current coding habits as possible?
    (Note that this does not apply to pieces of code where we ourselves
    obviously violated good coding practices, which unfortunately happens
    sometimes. But please indicate this in your PR so that we know what you
    rectified!)

Furthermore, make sure that the linter does not complain, which will check your code on every new commit. If the linter task fails, make sure to run yarn lint locally and check the file eslint_report.htm which will tell you precisely what went wrong.
Stay sharp, and thanks again!

@auto-assign auto-assign Bot requested a review from AlexRogalskiy August 22, 2022 11:53
@viezly
Copy link
Copy Markdown

viezly Bot commented Aug 22, 2022

This pull request is split into 3 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • .github
  • docs
  • reports

@jsoref jsoref changed the title Update to check-spelling@v0.0.20 ci: Update to check-spelling@v0.0.20 Aug 22, 2022
jsoref added 12 commits January 3, 2023 17:37
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref changed the title ci: Update to check-spelling@v0.0.20 ci: Update to check-spelling@v0.0.21 Jan 3, 2023
@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Jan 3, 2023

@AlexRogalskiy: what do I need to do to push this forward?

@github-actions
Copy link
Copy Markdown
Contributor

Greetings! Sorry to say but this is a very old issue that is probably not getting as much attention as it deservers. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Apr 27, 2026

@AlexRogalskiy would you accept an update? (you're stuck on v0.0.19 and it's been broken for ages, and the current version is v0.0.26... I can do a refresh, but only if it's likely to be accepted)

@AlexRogalskiy AlexRogalskiy merged commit 0b993da into AlexRogalskiy:master Apr 27, 2026
7 of 10 checks passed
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Apr 27, 2026

There we go, your PR got merged! Welcome to the party! 🔥

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2026
@jsoref jsoref deleted the spell-check branch April 27, 2026 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants