Updated to handle new update correctly#2
Open
JeppeSchildt wants to merge 3 commits intoAlexandrosKyriakakis:mainfrom
Open
Updated to handle new update correctly#2JeppeSchildt wants to merge 3 commits intoAlexandrosKyriakakis:mainfrom
JeppeSchildt wants to merge 3 commits intoAlexandrosKyriakakis:mainfrom
Conversation
Renaming of keys, now dropping rows with no values such as rest timers, correctly handling time
Removed the changes i made to make it run on my local system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed keys and their order. Changed the timestamp handling to work properly now. Dropping rows with no values in weight/reps (i.e notes or rest timers).
I dont understand why the csv path is current dir instead of parent dir, i.e why './Data/strong.csv' instead of '../Data/strong.csv', but i've left it as is.