relocate format_batch_with_env.sh into infrastructure/#3587
Open
davidsmejia wants to merge 2 commits into
Open
relocate format_batch_with_env.sh into infrastructure/#3587davidsmejia wants to merge 2 commits into
davidsmejia wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number
#3572
Purpose/Implementation Notes
The script is invoked exclusively from infrastructure/deploy.sh (six call sites, all relative to deploy.sh's CWD). Moving it adjacent to its only caller eliminates one of the two reasons the deploy flow had to traverse
../scripts/.→ ./format_batch_with_env.sh (×6)
The script itself is unchanged. It still sources ../scripts/common.sh from inside its own cd'd CWD (api/, foreman/, workers/) - that path is relative to runtime CWD, not the script's file location, so the relocation doesn't affect it. scripts/common.sh remains in place until we drop it later.
Methods
N/A
Types of changes
Functional tests
N/A
Checklist
Screenshots
N/A