Skip to content

infra/deploy.sh: drop scripts/common.sh source, inline its consumers#3589

Open
davidsmejia wants to merge 2 commits into
davidsmejia/3572-06-app-shell-callersfrom
davidsmejia/3572-07-infrastructure-callers
Open

infra/deploy.sh: drop scripts/common.sh source, inline its consumers#3589
davidsmejia wants to merge 2 commits into
davidsmejia/3572-06-app-shell-callersfrom
davidsmejia/3572-07-infrastructure-callers

Conversation

@davidsmejia
Copy link
Copy Markdown
Contributor

Issue Number

#3572

Purpose/Implementation Notes

  • infrastructure/deploy.sh only used two things from scripts/common.sh:
    • the $ALL_IMAGES list (consumed by the for-loop that builds per-image TF_VAR_*_docker_image vars) and get_deploy_repo (a two-line case mapping branch → Dockerhub namespace). Both are inlined now so this file no longer depends on scripts/.
  • ALL_IMAGES is now a local string literal, matching the expansion of common.sh's base api_base api foreman $WORKER_IMAGES.
  • get_deploy_repo is replaced with the two literal repo names (ccdlstaging / ccdl) at the only call site, with a comment naming what each is for.

Methods

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

N/A

Checklist

  • Lint and unit tests pass locally with my changes

Screenshots

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant