Skip to content

Commit 835fba1

Browse files
committed
fix(tool): avoid duplicate MCP preset injection
1 parent 0868174 commit 835fba1

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

agentscope-core/src/main/java/io/agentscope/core/tool/McpClientManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ Mono<Void> registerMcpClient(
183183
mcpTool.outputSchema())
184184
: null,
185185
mcpClientWrapper,
186-
toolPresetParams);
186+
null);
187187

188188
// Register with group, MCP client name, and preset parameters via
189189
// callback

agentscope-core/src/test/java/io/agentscope/core/tool/McpClientManagerTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,14 @@
1818
import static org.junit.jupiter.api.Assertions.assertEquals;
1919
import static org.junit.jupiter.api.Assertions.assertFalse;
2020
import static org.junit.jupiter.api.Assertions.assertNotNull;
21+
import static org.junit.jupiter.api.Assertions.assertNull;
2122
import static org.junit.jupiter.api.Assertions.assertTrue;
2223
import static org.mockito.Mockito.mock;
2324
import static org.mockito.Mockito.verify;
2425
import static org.mockito.Mockito.when;
2526

2627
import io.agentscope.core.tool.mcp.McpClientWrapper;
28+
import io.agentscope.core.tool.mcp.McpTool;
2729
import io.modelcontextprotocol.spec.McpSchema;
2830
import java.lang.reflect.Method;
2931
import java.util.ArrayList;
@@ -405,6 +407,8 @@ void testRegisterMcpClient_PreservesOutputSchemaInRegisteredTool() {
405407
verify(clientWrapper).listTools();
406408
assertNotNull(registeredTool[0]);
407409
assertEquals(outputSchema, registeredTool[0].getOutputSchema());
410+
assertTrue(registeredTool[0] instanceof McpTool);
411+
assertNull(((McpTool) registeredTool[0]).getPresetArguments());
408412
assertEquals("mcp-group", registeredGroupName[0]);
409413
assertEquals("test-client", registeredClientName[0]);
410414
assertEquals(toolPresetParams, registeredPresetParams[0]);

0 commit comments

Comments
 (0)