fix: sync chat_message rows on chat update

Author: Algorithm5838

backend/open_webui/models/chats.py

@@ -404,6 +404,9 @@ async def update_chat_by_id(self, id: str, chat: dict, db: AsyncSession | None =
 
                 await db.commit()
 
+                new_messages = (chat.get('history', {}) or {}).get('messages', {}) or {}
+                await self.reconcile_messages_by_chat_id(id, chat_item.user_id, new_messages)
+
                 return ChatModel.model_validate(chat_item)
         except Exception:
             return None
@@ -501,20 +504,13 @@ async def backfill_messages_by_chat_id(self, chat_id: str, user_id: str, message
     async def reconcile_messages_by_chat_id(
         self, chat_id: str, user_id: str, messages: dict[str, dict]
     ) -> None:
-        """Sync ``chat_message`` rows with the committed JSON blob.
+        """Upsert ``chat_message`` rows from the blob; never delete.
 
-        Upserts current messages via ``backfill_messages_by_chat_id``
-        and deletes orphaned rows whose message_id no longer appears
-        in the blob.  Best-effort: errors are logged but never raised.
+        Diff-based pruning (table − blob) is unsafe: a lost blob write
+        from a read-modify-write race would drop a still-valid row.
         """
         try:
             await self.backfill_messages_by_chat_id(chat_id, user_id, messages)
-
-            existing_map = await ChatMessages.get_messages_map_by_chat_id(chat_id)
-            if existing_map is not None:
-                orphaned_ids = set(existing_map.keys()) - set(messages.keys())
-                if orphaned_ids:
-                    await ChatMessages.delete_message_ids_by_chat_id(chat_id, orphaned_ids)
         except Exception as e:
             log.warning('Failed to reconcile chat_message rows for chat %s: %s', chat_id, e)
 

backend/open_webui/routers/chats.py

@@ -988,13 +988,6 @@ async def update_chat_by_id(
 
         chat = await Chats.update_chat_by_id(id, updated_chat, db=db)
 
-        # Reconcile chat_message rows with the committed blob.
-        # This is the only caller where the frontend pushes a full
-        # history with potential edits, deletions, or new branches.
-        messages = (updated_chat.get('history') or {}).get('messages') or {}
-        if messages:
-            await Chats.reconcile_messages_by_chat_id(id, user.id, messages)
-
         return ChatResponse(**chat.model_dump())
     else:
         raise HTTPException(