refac

Author: tjbck

backend/open_webui/models/feedbacks.py

@@ -215,6 +215,13 @@ def get_feedback_items(
             query = db.query(Feedback, User).join(User, Feedback.user_id == User.id)
 
             if filter:
+                # Apply model_id filter (exact match)
+                model_id = filter.get('model_id')
+                if model_id:
+                    query = query.filter(
+                        Feedback.data['model_id'].as_string() == model_id
+                    )
+
                 order_by = filter.get('order_by')
                 direction = filter.get('direction')
 
@@ -288,6 +295,17 @@ def get_all_feedback_ids(self, db: Optional[Session] = None) -> list[FeedbackIdR
                 .all()
             ]
 
+    def get_distinct_model_ids(self, db: Optional[Session] = None) -> list[str]:
+        """Get distinct model_ids from feedback data for filter dropdowns."""
+        with get_db_context(db) as db:
+            rows = (
+                db.query(Feedback.data['model_id'].as_string())
+                .filter(Feedback.data['model_id'].as_string().isnot(None))
+                .distinct()
+                .all()
+            )
+            return sorted([row[0] for row in rows if row[0]])
+
     def get_feedbacks_for_leaderboard(self, db: Optional[Session] = None) -> list[LeaderboardFeedbackData]:
         """Fetch only id and data for leaderboard computation (excludes snapshot/meta)."""
         with get_db_context(db) as db:

backend/open_webui/routers/evaluations.py

@@ -291,6 +291,11 @@ async def update_config(
     }
 
 
+@router.get('/feedbacks/models', response_model=list[str])
+async def get_feedback_model_ids(user=Depends(get_admin_user), db: Session = Depends(get_session)):
+    return Feedbacks.get_distinct_model_ids(db=db)
+
+
 @router.get('/feedbacks/all', response_model=list[FeedbackResponse])
 async def get_all_feedbacks(user=Depends(get_admin_user), db: Session = Depends(get_session)):
     feedbacks = Feedbacks.get_all_feedbacks(db=db)
@@ -309,8 +314,17 @@ async def delete_all_feedbacks(user=Depends(get_admin_user), db: Session = Depen
 
 
 @router.get('/feedbacks/all/export', response_model=list[FeedbackModel])
-async def export_all_feedbacks(user=Depends(get_admin_user), db: Session = Depends(get_session)):
+async def export_all_feedbacks(
+    model_id: Optional[str] = None,
+    user=Depends(get_admin_user),
+    db: Session = Depends(get_session),
+):
     feedbacks = Feedbacks.get_all_feedbacks(db=db)
+    if model_id:
+        feedbacks = [
+            f for f in feedbacks
+            if f.data and f.data.get('model_id') == model_id
+        ]
     return feedbacks
 
 
@@ -334,6 +348,7 @@ async def get_feedbacks(
     order_by: Optional[str] = None,
     direction: Optional[str] = None,
     page: Optional[int] = 1,
+    model_id: Optional[str] = None,
     user=Depends(get_admin_user),
     db: Session = Depends(get_session),
 ):
@@ -347,6 +362,8 @@ async def get_feedbacks(
         filter['order_by'] = order_by
     if direction:
         filter['direction'] = direction
+    if model_id:
+        filter['model_id'] = model_id
 
     result = Feedbacks.get_feedback_items(filter=filter, skip=skip, limit=limit, db=db)
     return result

src/lib/apis/evaluations/index.ts

@@ -161,13 +161,42 @@ export const getModelHistory = async (token: string = '', modelId: string, days:
 	return res;
 };
 
-export const getFeedbackItems = async (token: string = '', orderBy, direction, page) => {
+export const getFeedbackModelIds = async (token: string = '') => {
+	let error = null;
+
+	const res = await fetch(`${WEBUI_API_BASE_URL}/evaluations/feedbacks/models`, {
+		method: 'GET',
+		headers: {
+			Accept: 'application/json',
+			'Content-Type': 'application/json',
+			authorization: `Bearer ${token}`
+		}
+	})
+		.then(async (res) => {
+			if (!res.ok) throw await res.json();
+			return res.json();
+		})
+		.catch((err) => {
+			error = err.detail;
+			console.error(err);
+			return null;
+		});
+
+	if (error) {
+		throw error;
+	}
+
+	return res;
+};
+
+export const getFeedbackItems = async (token: string = '', orderBy, direction, page, modelId: string = '') => {
 	let error = null;
 
 	const searchParams = new URLSearchParams();
 	if (orderBy) searchParams.append('order_by', orderBy);
 	if (direction) searchParams.append('direction', direction);
 	if (page) searchParams.append('page', page.toString());
+	if (modelId) searchParams.append('model_id', modelId);
 
 	const res = await fetch(
 		`${WEBUI_API_BASE_URL}/evaluations/feedbacks/list?${searchParams.toString()}`,
@@ -200,10 +229,13 @@ export const getFeedbackItems = async (token: string = '', orderBy, direction, p
 	return res;
 };
 
-export const exportAllFeedbacks = async (token: string = '') => {
+export const exportAllFeedbacks = async (token: string = '', modelId: string = '') => {
 	let error = null;
 
-	const res = await fetch(`${WEBUI_API_BASE_URL}/evaluations/feedbacks/all/export`, {
+	const searchParams = new URLSearchParams();
+	if (modelId) searchParams.append('model_id', modelId);
+
+	const res = await fetch(`${WEBUI_API_BASE_URL}/evaluations/feedbacks/all/export?${searchParams.toString()}`, {
 		method: 'GET',
 		headers: {
 			Accept: 'application/json',