Skip to content

Commit e0b5529

Browse files
committed
fix: respect content edits and deleted blocks in output
1 parent 2aa7ef9 commit e0b5529

2 files changed

Lines changed: 108 additions & 5 deletions

File tree

backend/open_webui/utils/middleware.py

Lines changed: 42 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@
9898
convert_logit_bias_input_to_json,
9999
get_content_from_message,
100100
convert_output_to_messages,
101+
filter_output_by_content,
101102
strip_empty_content_blocks,
102103
)
103104
from open_webui.utils.tools import (
@@ -2164,16 +2165,52 @@ def process_messages_with_output(messages: list[dict]) -> list[dict]:
21642165
21652166
For assistant messages with 'output' field, produces properly formatted
21662167
OpenAI-style messages (tool_calls + tool results). Strips 'output' before LLM.
2168+
Respects content edits and dropped <details> blocks by filtering output items
2169+
against the stored content field before conversion.
21672170
"""
21682171
processed = []
21692172

21702173
for message in messages:
21712174
if message.get('role') == 'assistant' and message.get('output'):
2172-
# Use output items for clean OpenAI-format messages
2173-
output_messages = convert_output_to_messages(message['output'], raw=True)
2174-
if output_messages:
2175-
processed.extend(output_messages)
2176-
continue
2175+
# normalize; guard against None or list-typed content
2176+
content = message.get('content', '')
2177+
if not isinstance(content, str):
2178+
content = ''
2179+
2180+
# Drop output items for <details> blocks removed from content
2181+
filtered_output = filter_output_by_content(message['output'], content)
2182+
2183+
# Split content around <details> blocks; assign each text segment to
2184+
# the corresponding message item in order → preserves pre/post-tool placement
2185+
text_segs = [
2186+
s.strip()
2187+
for s in re.split(r'<details\b[^>]*>.*?</details>', content, flags=re.S)
2188+
]
2189+
seg_idx = 0
2190+
modified_output = []
2191+
for item in filtered_output:
2192+
if item.get('type') == 'message':
2193+
text = text_segs[seg_idx] if seg_idx < len(text_segs) else ''
2194+
seg_idx += 1
2195+
modified_output.append({
2196+
**item,
2197+
'content': [{'type': 'output_text', 'text': text}],
2198+
})
2199+
else:
2200+
modified_output.append(item)
2201+
2202+
output_messages = convert_output_to_messages(modified_output, raw=True)
2203+
# Trailing segments not consumed by message items → append as plain text
2204+
trailing = '\n'.join(s for s in text_segs[seg_idx:] if s).strip()
2205+
if trailing:
2206+
output_messages.append({'role': 'assistant', 'content': trailing})
2207+
elif not output_messages:
2208+
# No structured output at all; fall back to plain text from content
2209+
plain = '\n'.join(s for s in text_segs if s).strip()
2210+
if plain:
2211+
output_messages = [{'role': 'assistant', 'content': plain}]
2212+
processed.extend(output_messages)
2213+
continue
21772214

21782215
# Strip 'output' field before adding (LLM shouldn't see it)
21792216
clean_message = {k: v for k, v in message.items() if k != 'output'}

backend/open_webui/utils/misc.py

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,72 @@ def flush_pending():
282282
return messages
283283

284284

285+
def filter_output_by_content(output: list, content: str) -> list:
286+
"""
287+
Drop output items whose <details> block was removed from content.
288+
289+
Matches by id attribute. Items with no ID are kept for backward
290+
compatibility with content serialized before id= was added.
291+
Items whose type is entirely absent from content are dropped wholesale.
292+
Legacy: if a type is present with no id= attrs, keep the first N items
293+
of that type where N = the number of blocks of that type remaining in
294+
content, so individually deleted blocks are respected even without IDs.
295+
"""
296+
if not isinstance(output, list):
297+
return []
298+
if not isinstance(content, str):
299+
content = ''
300+
301+
present_ids = set(re.findall(r'<details\b[^>]*\bid="([^"]+)"', content))
302+
present_types = set(re.findall(r'<details\b[^>]*\btype="([^"]+)"', content))
303+
304+
# Map output item type → <details> type attribute value
305+
DETAILS_TYPE = {
306+
'function_call': 'tool_calls',
307+
'function_call_output': 'tool_calls',
308+
'reasoning': 'reasoning',
309+
'open_webui:code_interpreter': 'code_interpreter',
310+
}
311+
312+
# No <details> blocks: pass through if no structured item has an ID (pre-serialization legacy)
313+
if not present_types:
314+
if not any(item.get('call_id') or item.get('id')
315+
for item in output if DETAILS_TYPE.get(item.get('type', ''))):
316+
return list(output)
317+
318+
# types with ≥1 id= in content; others treated as legacy (pre-id=)
319+
types_with_ids = set(re.findall(r'<details\b[^>]*\btype="([^"]+)"[^>]*\bid="[^"]*"', content))
320+
types_with_ids |= set(re.findall(r'<details\b[^>]*\bid="[^"]*"[^>]*\btype="([^"]+)"', content))
321+
322+
# Legacy (no id=): count remaining blocks per type for positional matching
323+
type_block_counts = {}
324+
for t in re.findall(r'<details\b[^>]*\btype="([^"]+)"', content):
325+
type_block_counts[t] = type_block_counts.get(t, 0) + 1
326+
327+
filtered = []
328+
seen_legacy = {} # kept count per legacy type
329+
for item in output:
330+
details_type = DETAILS_TYPE.get(item.get('type', ''))
331+
if details_type is None:
332+
filtered.append(item) # non-visual item (e.g. 'message'): always keep
333+
continue
334+
if details_type not in present_types:
335+
continue # entire type removed from content: drop
336+
if details_type not in types_with_ids:
337+
# Legacy (no id=): keep first N items, N = block count in content
338+
n = type_block_counts.get(details_type, 0)
339+
if seen_legacy.get(details_type, 0) < n:
340+
filtered.append(item)
341+
seen_legacy[details_type] = seen_legacy.get(details_type, 0) + 1
342+
continue
343+
item_id = item.get('call_id') or item.get('id', '')
344+
if not item_id or item_id in present_ids:
345+
filtered.append(item) # no ID (old format) or ID still present: keep
346+
# else: ID not found in content → user deleted this block: drop
347+
348+
return filtered
349+
350+
285351
def get_last_user_message(messages: list[dict]) -> Optional[str]:
286352
message = get_last_user_message_item(messages)
287353
if message is None:

0 commit comments

Comments
 (0)