Skip to content

Commit 488e121

Browse files
committed
fix(search): remove |safe from search query to prevent XSS
1 parent 0aa23b0 commit 488e121

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/search.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ pub async fn find(req: Request<Body>) -> Result<Response<Body>, String> {
112112
subreddits,
113113
sub,
114114
params: SearchParams {
115-
q: query.replace('"', "&quot;"),
115+
q: query,
116116
sort,
117117
t: param(&path, "t").unwrap_or_default(),
118118
before: param(&path, "after").unwrap_or_default(),
@@ -138,7 +138,7 @@ pub async fn find(req: Request<Body>) -> Result<Response<Body>, String> {
138138
subreddits,
139139
sub,
140140
params: SearchParams {
141-
q: query.replace('"', "&quot;"),
141+
q: query,
142142
sort,
143143
t: param(&path, "t").unwrap_or_default(),
144144
before: param(&path, "after").unwrap_or_default(),

templates/search.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<div id="column_one">
1212
<form id="search_sort">
1313
<div class="search_widget_divider_box">
14-
<input id="search" type="text" name="q" placeholder="Search" value="{{ params.q|safe }}" title="Search redlib">
14+
<input id="search" type="text" name="q" placeholder="Search" value="{{ params.q }}" title="Search redlib">
1515
<div class="search_widget_divider_box">
1616
{% if sub != "" %}
1717
<div id="inside">
@@ -114,13 +114,13 @@
114114
{% if params.typed != "sr_user" %}
115115
<footer>
116116
{% if params.before != "" %}
117-
<a href="?q={{ params.q|safe }}&restrict_sr={{ params.restrict_sr }}
117+
<a href="?q={{ params.q }}&restrict_sr={{ params.restrict_sr }}
118118
&sort={{ params.sort }}&t={{ params.t }}
119119
&before={{ params.before }}" accesskey="P">PREV</a>
120120
{% endif %}
121121

122122
{% if params.after != "" %}
123-
<a href="?q={{ params.q|safe }}&restrict_sr={{ params.restrict_sr }}
123+
<a href="?q={{ params.q }}&restrict_sr={{ params.restrict_sr }}
124124
&sort={{ params.sort }}&t={{ params.t }}
125125
&after={{ params.after }}" accesskey="N">NEXT</a>
126126
{% endif %}

0 commit comments

Comments
 (0)