Skip to content

Week 8 Peer to Peer programming  #6

@henask12

Description

@henask12

Review for Peer

Hi @Alibaba2023

Overall, the code looks good, but we have a few suggestions for improvement:

  • Show the "required" message only when clicking the add button and the input field is empty:

  • Currently, the "required" attribute is always present on the input field, which displays the validation message even when the add button is not clicked. To address this, you can remove the "required" attribute from the input field and add a check inside the addTask() function to display the message only when necessary.

  • Remove the refresh icon:

  • If the refresh icon is not functioning as intended, it might be better to remove it from the code altogether to avoid confusion for users.

  • Start indexing from 1 instead of 0:

  • According to the requirements, the index should start from 1 rather than 0. You can update the reindex() function as mentioned earlier to achieve this.

  • Change the title from "Webpack Exercise" to "Todo List":

  • Update the title of the page to "Todo List" to provide a more descriptive and appropriate heading for the application.

  • Modularize the code:

  • Consider breaking down the code into smaller, modular components. This can improve code readability, maintainability, and allow for easier testing and reusability. You can separate concerns by creating separate files for components like Task, TaskList, and TaskItem, and then import and use them where necessary.

By addressing these suggestions, you can enhance the user experience, conform to the requirements, and improve the code organization. Great job so far, and we hope these suggestions help you further improve your Todo List application.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions