Skip to content

ITS3: GPU tracking#14156

Merged
davidrohr merged 2 commits into
AliceO2Group:devfrom
f3sch:gpu/its3
Apr 14, 2025
Merged

ITS3: GPU tracking#14156
davidrohr merged 2 commits into
AliceO2Group:devfrom
f3sch:gpu/its3

Conversation

@f3sch

@f3sch f3sch commented Apr 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

allows tracking for ITS3 on gpu

@github-actions

github-actions Bot commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild

alibuild commented Apr 8, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 9074d8a at 2025-04-08 15:32:

## sw/BUILD/SHERPA-latest/log
configure: error: Sqlite3 required but not found.

Full log here.

davidrohr
davidrohr previously approved these changes Apr 9, 2025
View reviewed changes

@davidrohr davidrohr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for my minor comment below, which you might want to consider.

Comment thread GPU/Workflow/src/GPUWorkflowSpec.cxx Outdated
@alibuild

alibuild commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 6484aa5 at 2025-04-10 11:28:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14156-slc9_x86-64/0/GPU/Workflow/src/GPUWorkflowITS.cxx:44:91: error: 'struct o2::gpu::GPURecoWorkflowSpec::Config' has no member named 'processITSMC'; did you mean 'processMC'?
/sw/SOURCES/O2/14156-slc9_x86-64/0/GPU/Workflow/src/GPUWorkflowITS.cxx:48:89: error: 'struct o2::gpu::GPURecoWorkflowSpec::Config' has no member named 'processITSMC'; did you mean 'processMC'?
ninja: build stopped: subcommand failed.

Full log here.

@f3sch
ITS3: GPU tracking
27cf943 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@alibuild

alibuild commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 240930b at 2025-04-10 18:19:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile sim.log


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/e757374b075c4a37e825121da256bf633fc86bb2/slc9_x86-64/o2checkcode/1.0-local123/etc/modulefiles
++ cat
--

Full log here.

@f3sch

f3sch commented Apr 12, 2025

Copy link
Copy Markdown
Collaborator Author

@davidrohr the error should be unrelated and fullCI_slc9 did built, so from my side this would be ready.

davidrohr
davidrohr reviewed Apr 13, 2025
View reviewed changes
Comment thread GPU/Workflow/src/GPUWorkflowITS.cxx
@f3sch
GPU: Add ITS3 to workflow
71eb2fd 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@alibuild

alibuild commented Apr 13, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 71eb2fd at 2025-04-13 14:14:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile sim.log


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/0e2998d39621675aad050824d68fb93a263e7465/slc9_x86-64/o2checkcode/1.0-local159/etc/modulefiles
++ cat
--

Full log here.

@davidrohr davidrohr enabled auto-merge (rebase) April 13, 2025 14:31
@davidrohr davidrohr disabled auto-merge April 14, 2025 07:06
@davidrohr davidrohr merged commit fad8881 into AliceO2Group:dev Apr 14, 2025
@f3sch f3sch deleted the gpu/its3 branch April 14, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidrohr davidrohr davidrohr approved these changes

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@arossi81 arossi81 Awaiting requested review from arossi81 arossi81 is a code owner

@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner

@fprino fprino Awaiting requested review from fprino

@shahor02 shahor02 Awaiting requested review from shahor02

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@f3sch @alibuild @davidrohr