remove unecessary changes

Author: xsalonx

lib/public/views/QcFlags/ActiveColumns/gaqFlagsActiveColumns.js

@@ -28,7 +28,6 @@ import { h, iconBan, iconWarning } from '/js/src/index.js';
  * @return {Component} display of aggregated quality
  */
 const formatGeneralQuality = (contributingFlags, gaqDetectors) => {
-    const missingFlags = contributingFlags.length !== gaqDetectors.length;
     const flagTypes = contributingFlags.map(({ flagType }) => flagType);
     const allGood = flagTypes.every(({ bad }) => !bad);
     const someBadNotReproducible = flagTypes.some(({ bad, mcReproducible }) => bad && !mcReproducible);
@@ -45,9 +44,7 @@ const formatGeneralQuality = (contributingFlags, gaqDetectors) => {
         : null;
 
     let qualityDisplay = null;
-    if (missingFlags) {
-        qualityDisplay = badge('ND', { color: QcSummaryColors.INCALCULABLE_COVERAGE });
-    } else if (allGood) {
+    if (allGood) {
         qualityDisplay = badge('good', { color: QcSummaryColors.ALL_GOOD });
     } else if (someBadNotReproducible) {
         qualityDisplay = badge('bad', { color: QcSummaryColors.ALL_BAD });

test/public/qcFlags/gaqOverview.test.js

@@ -66,64 +66,36 @@ module.exports = () => {
         // eslint-disable-next-line require-jsdoc
         const validateDate = (date) => date === '-' || !isNaN(dateAndTime.parse(date, 'DD/MM/YYYY hh:mm:ss'));
         const tableDataValidators = {
-            generalQuality: (generalQuality) => ['ND', 'good', 'bad', 'MC.R'].includes(generalQuality),
+            generalQuality: (generalQuality) => ['good', 'bad', 'MC.R'].includes(generalQuality),
             from: (timestamp) => timestamp === 'Whole run coverage' || validateDate(timestamp),
             to: (timestamp) => timestamp === 'Whole run coverage' || validateDate(timestamp),
         };
 
         await validateTableData(page, new Map(Object.entries(tableDataValidators)));
 
-        await waitForTableLength(page, 7);
+        await waitForTableLength(page, 3);
         expect(await getTableContent(page)).to.have.all.deep.ordered.members([
             [
-                'ND',
-                '08/08/2019\n13:00:00',
-                '08/08/2019\n22:43:20',
-                '',
-                '',
-            ],
-            [
-                'ND',
+                'MC.R',
                 '08/08/2019\n22:43:20',
                 '09/08/2019\n04:16:40',
                 'Limited Acceptance MC Reproducible',
                 '',
             ],
             [
-                'ND',
-                '09/08/2019\n04:16:40',
-                '09/08/2019\n05:40:00',
-                '',
-                '',
-            ],
-            [
-                'ND',
+                'bad',
                 '09/08/2019\n05:40:00',
                 '09/08/2019\n07:03:20',
-                'Limited Acceptance MC Not Reproducible',
-                '',
-            ],
-            [
-                'ND',
-                '09/08/2019\n07:03:20',
-                '09/08/2019\n08:26:40',
-                '',
+                'Limited acceptance',
                 '',
             ],
             [
-                'ND',
+                'bad',
                 '09/08/2019\n08:26:40',
                 '09/08/2019\n09:50:00',
                 'Bad',
                 '',
             ],
-            [
-                'ND',
-                '09/08/2019\n09:50:00',
-                '09/08/2019\n14:00:00',
-                '',
-                '',
-            ],
         ]);
 
         await waitForNavigation(page, () => pressElement(page, '#breadcrumb-data-pass-name a', true));
@@ -139,7 +111,7 @@ module.exports = () => {
         await waitForTableLength(page, 7);
         expect(await getTableContent(page)).to.have.all.deep.ordered.members([
             [
-                'ND',
+                'good',
                 '08/08/2019\n13:00:00',
                 '08/08/2019\n22:43:20',
                 '',
@@ -153,7 +125,7 @@ module.exports = () => {
                 'Good',
             ],
             [
-                'ND',
+                'good',
                 '09/08/2019\n04:16:40',
                 '09/08/2019\n05:40:00',
                 '',
@@ -163,11 +135,11 @@ module.exports = () => {
                 'bad',
                 '09/08/2019\n05:40:00',
                 '09/08/2019\n07:03:20',
-                'Limited Acceptance MC Not Reproducible',
+                'Limited acceptance',
                 'Good',
             ],
             [
-                'ND',
+                'good',
                 '09/08/2019\n07:03:20',
                 '09/08/2019\n08:26:40',
                 '',
@@ -181,7 +153,7 @@ module.exports = () => {
                 'Good',
             ],
             [
-                'ND',
+                'good',
                 '09/08/2019\n09:50:00',
                 '09/08/2019\n14:00:00',
                 '',