[O2B-1115] Implement runs per data pass API (#1332)

* add migration

* add references

* add model associations

* add jsonRequest method

* add abstract synchronizer

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* simplify

* cleanup

* cleanup

* add monalisa service

* docs annotation

* refactor

* change main method to return void instead of boolean

* db action

* handle field mappings

* remove abstract class

* single concrete class

* add variables

* use env vars

* linter

* refactor

* docs refactor

* typo

* refactor

* refactor

* fixes

* refactored

* not then chain

* refactor{

* types

* rename

* use seuqlize to fetch last runs

* add type, use URL class

* remove file read

* docs

* add synchronizer factory

* add docs

* cleanup

* no await

* refactor

* typdef

* refactor context

* rename

* docs

* docs

* rename

* working

* rename

* rename

* add test for getting data passes

* add test for getting data passes

* sync test

* add test for data pass sync

* amend data

* add details fetching

* add env

* fetching data passes and details

* rename

* add tests

* rename

* reduce test data size

* docs

* refactor

* typo

* typo

* docs

* rename

* docs

* cleanup

* remove dead code

* add service

* cleanup

* add filtering by periods

* add data passes seeders

* rename

* add data passes service tests

* test

* revoke unfound changes

* add controllers

* rename

* refactor

* refactor

* refactor

* no dependency

* refactor

* refactor

* refactor:

* reaname'

* rename

* cleanup

* docs

* reaname

* refactor

* add router

* restore

* amend test

* expose api

* add test

* add tests

* amend

* docs

* amend test

* amend

* add Data Passes page

* expose page

* styling

* add reset method

* rename

* use sorting

* add unit

* docs

* add filtering by data pass id

* add test

* amend test

* amend test

* use name instead of id

* amend test

* rename

* rename

* use filtering by name

* add test

* use generic model

* aboid undefined destruciton error

* use proper method

* cleanup

* linter

* make uppercase

* amend test

* use id

* use builder

* simplify

* remove unncessary stm

* use raw query

* cleanup

Author: xsalonx

lib/database/utilities/QueryBuilder.js

@@ -356,22 +356,6 @@ class WhereAssociationQueryBuilder extends WhereQueryBuilder {
         this._sequelize = sequelize;
 
         this.association = association;
-        const sequelizeAssociation = this.queryBuilder.model.associations[this.association];
-
-        /**
-         * In order to utilise the builder with association properly,
-         * it is needed to know cardinality of the association.
-         * Existance of property 'through' indicated
-         * that the association is many-to-many, otherwise, it is one-to-many or one-to-one.
-         * Depending whether it is true or not a name of target model
-         * will be acquired in different ways.
-         * Also construction of 'where clause' in @see _op
-         * is dependent on that cardinality.
-         */
-        this.isAssociationThroughJunctionTable = Boolean(sequelizeAssociation.through);
-        this.associatedModelName = this.isAssociationThroughJunctionTable ?
-            sequelizeAssociation.toTarget.as
-            : sequelizeAssociation.target.name;
     }
 
     /**
@@ -382,17 +366,11 @@ class WhereAssociationQueryBuilder extends WhereQueryBuilder {
      */
     _op(operation) {
         this.queryBuilder.include({
-            model: this._sequelize.models[this.associatedModelName],
-            as: this.association,
+            association: this.association,
             required: true,
-            through: this.isAssociationThroughJunctionTable ? {
-                where: {
-                    [`${this.associatedModelName}_${this.column}`]: operation,
-                },
-            } : undefined,
-            where: !this.isAssociationThroughJunctionTable ? {
+            where: {
                 [this.column]: operation,
-            } : undefined,
+            },
         });
 
         return this.queryBuilder;

lib/domain/dtos/filters/RunFilterDto.js

@@ -54,6 +54,7 @@ exports.RunFilterDto = Joi.object({
     odcTopologyFullName: Joi.string().trim(),
     detectors: DetectorsFilterDto,
     lhcPeriods: Joi.string().trim(),
+    dataPassIds: Joi.array().items(Joi.number()),
     runTypes: CustomJoi.stringArray().items(Joi.string()).single().optional(),
     updatedAt: FromToFilterDto,
 });

lib/usecases/run/GetAllRunsUseCase.js

@@ -48,6 +48,7 @@ class GetAllRunsUseCase {
                 epn,
                 fillNumbers,
                 lhcPeriods,
+                dataPassIds,
                 nDetectors,
                 nEpns,
                 nFlps,
@@ -233,6 +234,20 @@ class GetAllRunsUseCase {
                 });
             }
 
+            if (dataPassIds) {
+                const runNumbers = (await RunRepository.findAll({
+                    attributes: ['runNumber'],
+                    raw: true,
+                    include: [
+                        {
+                            association: 'dataPass',
+                            where: { id: { [Op.in]: dataPassIds } },
+                        },
+                    ],
+                })).map(({ runNumber }) => runNumber);
+                filteringQueryBuilder.where('runNumber').oneOf(...runNumbers);
+            }
+
             if (tags && tags.values.length > 0) {
                 if (tags.operation === 'and') {
                     const runsWithExpectedTags = await RunRepository.findAll({

test/api/runs.test.js

@@ -219,6 +219,15 @@ module.exports = () => {
             expect(data.every(({ definition }) => definition === RunDefinition.Physics)).to.be.true;
         });
 
+        it ('should succefully filter on data pass id', async () => {
+            const response = await request(server).get('/api/runs?filter[dataPassIds][]=2&filter[dataPassIds][]=3');
+            expect(response.status).to.equal(200);
+
+            const { data } = response.body;
+            expect(data).to.lengthOf(7);
+            expect(data.map(({ runNumber }) => runNumber)).to.have.all.members([1, 2, 55, 49, 54, 56, 105]);
+        });
+
         it('should return 400 if o2start "to" date is before "from" date', (done) => {
             request(server)
                 .get('/api/runs?filter[o2start][from]=946771200000&filter[o2start][to]=946684800000')